Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Option and niche optimization in FFI #3015

Open
mversic opened this issue Dec 15, 2022 · 0 comments
Open

Option and niche optimization in FFI #3015

mversic opened this issue Dec 15, 2022 · 0 comments
Assignees
@mversic
Labels
iroha2-dev The re-implementation of a BFT hyperledger in RUST

Comments

@mversic
Copy link
Contributor

mversic commented Dec 15, 2022 •
edited
Loading

There is no support for converting Option<T> for types which have no niche optimization.

There is some basic support for niche optimizations in FFI, often times inadequate. A good example of this is NumericValue which had to be marked as opaque because of a very specific issue where &T has a niche value but out pointer of Option<&T> doesn't. This is and issue specific for for NonLocals which are Cloned (such as NumericValue)
@mversic mversic added the iroha2-dev The re-implementation of a BFT hyperledger in RUST label Dec 15, 2022
@mversic mversic self-assigned this Dec 15, 2022
mversic added a commit to mversic/iroha that referenced this issue Mar 29, 2023
@mversic
[feature] hyperledger-iroha#3015: Support for niche optimization in FFI
1a587f0 
Signed-off-by: Marin Veršić <marin.versic101@gmail.com>
mversic added a commit to mversic/iroha that referenced this issue Mar 29, 2023
@mversic
[feature] hyperledger-iroha#3015: Support for niche optimization in FFI
4e1fcbf 
Signed-off-by: Marin Veršić <marin.versic101@gmail.com>
mversic added a commit to mversic/iroha that referenced this issue Mar 30, 2023
@mversic
[feature] hyperledger-iroha#3015: Support for niche optimization in FFI
cd2e359 
Signed-off-by: Marin Veršić <marin.versic101@gmail.com>
mversic added a commit to mversic/iroha that referenced this issue Mar 30, 2023
@mversic
[feature] hyperledger-iroha#3015: Support for niche optimization in FFI
64da6b0 
Signed-off-by: Marin Veršić <marin.versic101@gmail.com>
mversic added a commit to mversic/iroha that referenced this issue Mar 30, 2023
@mversic
[feature] hyperledger-iroha#3015: Support for niche optimization in FFI
1eb03af 
Signed-off-by: Marin Veršić <marin.versic101@gmail.com>
mversic added a commit to mversic/iroha that referenced this issue Mar 30, 2023
@mversic
[feature] hyperledger-iroha#3015: Support for niche optimization in FFI
4f73bdd 
Signed-off-by: Marin Veršić <marin.versic101@gmail.com>
mversic added a commit to mversic/iroha that referenced this issue Mar 30, 2023
@mversic
[feature] hyperledger-iroha#3015: Support for niche optimization in FFI
aa3c070 
Signed-off-by: Marin Veršić <marin.versic101@gmail.com>
mversic added a commit to mversic/iroha that referenced this issue Mar 30, 2023
@mversic
[feature] hyperledger-iroha#3015: Support for niche optimization in FFI
3f4e756 
Signed-off-by: Marin Veršić <marin.versic101@gmail.com>
mversic added a commit to mversic/iroha that referenced this issue Mar 30, 2023
@mversic
[feature] hyperledger-iroha#3015: Support for niche optimization in FFI
0c2aa71 
Signed-off-by: Marin Veršić <marin.versic101@gmail.com>
mversic added a commit to mversic/iroha that referenced this issue Mar 31, 2023
@mversic
[feature] hyperledger-iroha#3015: Support for niche optimization in FFI
06536c8 
Signed-off-by: Marin Veršić <marin.versic101@gmail.com>
mversic added a commit to mversic/iroha that referenced this issue Mar 31, 2023
@mversic
[feature] hyperledger-iroha#3015: Support for niche optimization in FFI
2ad8607 
Signed-off-by: Marin Veršić <marin.versic101@gmail.com>
mversic added a commit to mversic/iroha that referenced this issue Apr 1, 2023
@mversic
[feature] hyperledger-iroha#3015: Support for niche optimization in FFI
81c8cad 
Signed-off-by: Marin Veršić <marin.versic101@gmail.com>
mversic added a commit to mversic/iroha that referenced this issue Apr 1, 2023
@mversic
[feature] hyperledger-iroha#3015: Support for niche optimization in FFI
ef6bd1d 
Signed-off-by: Marin Veršić <marin.versic101@gmail.com>
mversic added a commit to mversic/iroha that referenced this issue Apr 7, 2023
@mversic
[feature] hyperledger-iroha#3015: Support for niche optimization in FFI
744f1f0 
Signed-off-by: Marin Veršić <marin.versic101@gmail.com>
mversic added a commit to mversic/iroha that referenced this issue Apr 7, 2023
@mversic
[feature] hyperledger-iroha#3015: Support for niche optimization in FFI
d1c9067 
Signed-off-by: Marin Veršić <marin.versic101@gmail.com>
mversic added a commit to mversic/iroha that referenced this issue Apr 12, 2023
@mversic
[feature] hyperledger-iroha#3015: Support for niche optimization in FFI
8292690 
Signed-off-by: Marin Veršić <marin.versic101@gmail.com>
mversic added a commit to mversic/iroha that referenced this issue Apr 12, 2023
@mversic
[feature] hyperledger-iroha#3015: Support for niche optimization in FFI
f1e0bca 
Signed-off-by: Marin Veršić <marin.versic101@gmail.com>
mversic added a commit to mversic/iroha that referenced this issue Apr 12, 2023
@mversic
[feature] hyperledger-iroha#3015: Support for niche optimization in FFI
2cd77e8 
Signed-off-by: Marin Veršić <marin.versic101@gmail.com>
mversic added a commit to mversic/iroha that referenced this issue Apr 12, 2023
@mversic
[feature] hyperledger-iroha#3015: Support for niche optimization in FFI
74e806d 
Signed-off-by: Marin Veršić <marin.versic101@gmail.com>
mversic added a commit to mversic/iroha that referenced this issue Apr 12, 2023
@mversic
[feature] hyperledger-iroha#3015: Support for niche optimization in FFI
3536264 
Signed-off-by: Marin Veršić <marin.versic101@gmail.com>
mversic added a commit to mversic/iroha that referenced this issue Apr 12, 2023
@mversic
[feature] hyperledger-iroha#3015: Support for niche optimization in FFI
a6077f2 
Signed-off-by: Marin Veršić <marin.versic101@gmail.com>
mversic added a commit to mversic/iroha that referenced this issue Apr 13, 2023
@mversic
[feature] hyperledger-iroha#3015: Support for niche optimization in FFI
4679a27 
Signed-off-by: Marin Veršić <marin.versic101@gmail.com>
mversic added a commit to mversic/iroha that referenced this issue Apr 13, 2023
@mversic
[feature] hyperledger-iroha#3015: Support for niche optimization in FFI
c02d661 
Signed-off-by: Marin Veršić <marin.versic101@gmail.com>
mversic added a commit to mversic/iroha that referenced this issue Apr 13, 2023
@mversic
[feature] hyperledger-iroha#3015: Support for niche optimization in FFI
d279d04 
Signed-off-by: Marin Veršić <marin.versic101@gmail.com>
mversic added a commit to mversic/iroha that referenced this issue Apr 14, 2023
@mversic
[feature] hyperledger-iroha#3015: Support for niche optimization in FFI
96edd35 
Signed-off-by: Marin Veršić <marin.versic101@gmail.com>
mversic added a commit to mversic/iroha that referenced this issue Apr 14, 2023
@mversic
[feature] hyperledger-iroha#3015: Support for niche optimization in FFI
825a371 
Signed-off-by: Marin Veršić <marin.versic101@gmail.com>
mversic added a commit to mversic/iroha that referenced this issue Apr 18, 2023
@mversic
[feature] hyperledger-iroha#3015: Support for niche optimization in FFI
df383b9 
Signed-off-by: Marin Veršić <marin.versic101@gmail.com>
mversic added a commit to mversic/iroha that referenced this issue Apr 18, 2023
@mversic
[feature] hyperledger-iroha#3015: Support for niche optimization in FFI
9744f20 
Signed-off-by: Marin Veršić <marin.versic101@gmail.com>
@mversic mversic mentioned this issue Apr 18, 2023
Merged
5 tasks
mversic added a commit that referenced this issue Apr 20, 2023
@mversic
[feature] #3015: Support for niche optimization in FFI (#3336)
4da5b48 
Signed-off-by: Marin Veršić <marin.versic101@gmail.com>
appetrosyan pushed a commit that referenced this issue Jun 5, 2023
@mversic @appetrosyan
[feature] #3015: Support for niche optimization in FFI (#3336)
3fc9d1c 
Signed-off-by: Marin Veršić <marin.versic101@gmail.com>
mversic added a commit that referenced this issue Oct 17, 2023
@mversic
[feature] #3015: Support for niche optimization in FFI (#3336)
c1f4bed 
Signed-off-by: Marin Veršić <marin.versic101@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mversic mversic

Labels
iroha2-dev The re-implementation of a BFT hyperledger in RUST
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mversic