Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[refactor]: Migrate to tokio actors #3362

Closed
Erigara opened this issue Apr 11, 2023 · 0 comments
Closed

[refactor]: Migrate to tokio actors #3362

Erigara opened this issue Apr 11, 2023 · 0 comments
Assignees
@Erigara
Labels
iroha2-dev The re-implementation of a BFT hyperledger in RUST Refactor Improvement to overall code quality

Comments

@Erigara
Copy link
Contributor

Erigara commented Apr 11, 2023

Currently we are using custom actor framework iroha_actor for some subsystems of iroha2 which is limited in certain ways.
Firstly it's impossible to express state transitions of actor without using enums which leads to matching all over the place.
Secondly current actor framework leads to spaghetti code.
Adoption of plain tokio actors will help us with this limitations and provide more versatility in terms of communication between actors.
@Erigara Erigara added iroha2-dev The re-implementation of a BFT hyperledger in RUST Refactor Improvement to overall code quality labels Apr 11, 2023
@Erigara Erigara self-assigned this Apr 11, 2023
@Erigara Erigara mentioned this issue Apr 11, 2023
Merged
5 tasks
Erigara added a commit to Erigara/iroha that referenced this issue Apr 13, 2023
@Erigara
[refactor] hyperledger-iroha#3362: Migrate to tokio actors
3380219 
Signed-off-by: Shanin Roman <shanin1000@yandex.ru>
Erigara added a commit to Erigara/iroha that referenced this issue Apr 13, 2023
@Erigara
[refactor] hyperledger-iroha#3362: Migrate to tokio actors
c82e128 
Signed-off-by: Shanin Roman <shanin1000@yandex.ru>
appetrosyan pushed a commit that referenced this issue Apr 13, 2023
@Erigara @appetrosyan
[refactor] #3362: Migrate to tokio actors
3a3c043 
Signed-off-by: Shanin Roman <shanin1000@yandex.ru>
@Erigara Erigara closed this as completed Apr 19, 2023
appetrosyan pushed a commit that referenced this issue Jun 5, 2023
@Erigara @appetrosyan
[refactor] #3362: Migrate to tokio actors
c14894d 
Signed-off-by: Shanin Roman <shanin1000@yandex.ru>
mversic pushed a commit that referenced this issue Oct 17, 2023
@Erigara @mversic
[refactor] #3362: Migrate to tokio actors
dd49c3e 
Signed-off-by: Shanin Roman <shanin1000@yandex.ru>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Erigara Erigara

Labels
iroha2-dev The re-implementation of a BFT hyperledger in RUST Refactor Improvement to overall code quality
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Erigara