Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

iroha_wasm_builder: Implement optimization #3628

Closed
Arjentix opened this issue Jun 20, 2023 · 0 comments
Closed

iroha_wasm_builder: Implement optimization #3628

Arjentix opened this issue Jun 20, 2023 · 0 comments
Assignees
@Arjentix @timofeevmd
Labels
iroha2-dev The re-implementation of a BFT hyperledger in RUST Optimization Something isn't working as well as it should QA-confirmed This bug is reproduced and needs a fix

Comments

@Arjentix
Copy link
Contributor

Arjentix commented Jun 20, 2023 •
edited
Loading

Currently optimize() does nothing. Need to call wasm-opt from it and optimize the output binary.

How to test

You will see that binaries we build like validator.wasm will take much less space
@Arjentix Arjentix added the iroha2-dev The re-implementation of a BFT hyperledger in RUST label Jun 20, 2023
@Arjentix Arjentix self-assigned this Jun 20, 2023
@Arjentix Arjentix added the Optimization Something isn't working as well as it should label Jun 20, 2023
Arjentix added a commit to Arjentix/iroha that referenced this issue Jun 21, 2023
@Arjentix
[feature] hyperledger-iroha#3628: Implement iroha_wasm_builder opti…
10ba572 
…mization

Signed-off-by: Daniil Polyakov <arjentix@gmail.com>
@Arjentix Arjentix mentioned this issue Jun 21, 2023
Merged
5 tasks
Arjentix added a commit to Arjentix/iroha that referenced this issue Jun 22, 2023
@Arjentix
[feature] hyperledger-iroha#3628: Implement iroha_wasm_builder opti…
9192fc0 
…mization

Signed-off-by: Daniil Polyakov <arjentix@gmail.com>
Arjentix added a commit to Arjentix/iroha that referenced this issue Jun 22, 2023
@Arjentix
[feature] hyperledger-iroha#3628: Implement iroha_wasm_builder opti…
ffb375b 
…mization

Signed-off-by: Daniil Polyakov <arjentix@gmail.com>
Arjentix added a commit that referenced this issue Jun 22, 2023
@Arjentix
[feature] #3628: Implement iroha_wasm_builder optimization (#3635)
3e114f0 
Signed-off-by: Daniil Polyakov <arjentix@gmail.com>
@timofeevmd timofeevmd self-assigned this Jun 26, 2023
@timofeevmd timofeevmd added the QA-confirmed This bug is reproduced and needs a fix label Jun 26, 2023
mversic pushed a commit that referenced this issue Oct 17, 2023
@Arjentix @mversic
[feature] #3628: Implement iroha_wasm_builder optimization (#3635)
14ab85f 
Signed-off-by: Daniil Polyakov <arjentix@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Arjentix Arjentix

@timofeevmd timofeevmd

Labels
iroha2-dev The re-implementation of a BFT hyperledger in RUST Optimization Something isn't working as well as it should QA-confirmed This bug is reproduced and needs a fix
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Arjentix @timofeevmd