Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ci] Check that kagami validator is runnable as standalone #3700

Closed
ilchu opened this issue Jul 12, 2023 · 1 comment
Closed

[ci] Check that kagami validator is runnable as standalone #3700

ilchu opened this issue Jul 12, 2023 · 1 comment
Assignees
@ilchu
Labels
CI good first issue Good for newcomers iroha2-dev The re-implementation of a BFT hyperledger in RUST

Comments

@ilchu
Copy link
Contributor

ilchu commented Jul 12, 2023

Feature request

Add a CI check to ensure that now kagami validator can be run as e.g. target/debug/kagami <cmd>, i.e. with no CARGO_* env variables set.

Motivation

kagami being truly portable makes it an independent tool just as it should be.

Who can help?

@ilchu
@ilchu ilchu added good first issue Good for newcomers iroha2-dev The re-implementation of a BFT hyperledger in RUST CI labels Jul 12, 2023
@ilchu ilchu mentioned this issue Jul 12, 2023
Merged
3 tasks
@ilchu ilchu self-assigned this Jul 14, 2023
ilchu added a commit to ilchu/iroha that referenced this issue Jul 19, 2023
@ilchu
[ci] hyperledger-iroha#3700: CI check for kagami validator
ced4fc5
ilchu added a commit to ilchu/iroha that referenced this issue Jul 19, 2023
@ilchu
[ci] hyperledger-iroha#3700: CI check for kagami validator
4dd517d
ilchu added a commit to ilchu/iroha that referenced this issue Jul 19, 2023
@ilchu
[ci] hyperledger-iroha#3700: CI check for kagami validator
af12c1f
@ilchu ilchu mentioned this issue Jul 19, 2023
Closed
5 tasks
ilchu added a commit to ilchu/iroha that referenced this issue Jul 20, 2023
@ilchu
[ci] hyperledger-iroha#3700: CI check for kagami validator
3225084
ilchu added a commit to ilchu/iroha that referenced this issue Jul 20, 2023
@ilchu
[ci] hyperledger-iroha#3700: CI check for kagami validator
06ba2a7 
Signed-off-by: Ilia Churin <churin.ilya@gmail.com>
ilchu added a commit to ilchu/iroha that referenced this issue Jul 24, 2023
@ilchu
[ci] hyperledger-iroha#3700: CI check for kagami validator
d0b4432 
Signed-off-by: Ilia Churin <churin.ilya@gmail.com>
@appetrosyan
Copy link
Contributor

We have decided that the extra complexity is not worth the marginal convenience in an esoteric use case.

@appetrosyan appetrosyan closed this as not planned Won't fix, can't repro, duplicate, stale Jul 24, 2023
@0x009922 0x009922 mentioned this issue Aug 22, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ilchu ilchu

Labels
CI good first issue Good for newcomers iroha2-dev The re-implementation of a BFT hyperledger in RUST
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@appetrosyan @ilchu