Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Return sending blocks to observing peers #4387

Closed
Erigara opened this issue Mar 25, 2024 · 0 comments
Closed

Return sending blocks to observing peers #4387

Erigara opened this issue Mar 25, 2024 · 0 comments
Assignees
@Erigara @timofeevmd
Labels
Consensus This issue is related to the Sumeragi consensus iroha2-dev The re-implementation of a BFT hyperledger in RUST QA-confirmed This bug is reproduced and needs a fix

Comments

@Erigara
Copy link
Contributor

Erigara commented Mar 25, 2024

At some point we decided not to send blocks to observing peers.
In long run this decision resulted in observing peers lagging behind which affects resilience of the network.
Topology is rotated but lagging peers can't participate in consensus.

Current approach was to manipulate block sync config parameters, but this turned out to be very subtle approach.
@Erigara Erigara added iroha2-dev The re-implementation of a BFT hyperledger in RUST Consensus This issue is related to the Sumeragi consensus labels Mar 25, 2024
@Erigara Erigara self-assigned this Mar 26, 2024
Erigara added a commit to Erigara/iroha that referenced this issue Mar 27, 2024
@Erigara
[refactor] hyperledger-iroha#4387: Send blocks to observing peers
1a1f7ce 
Signed-off-by: Shanin Roman <shanin1000@yandex.ru>
@Erigara Erigara mentioned this issue Mar 27, 2024
Merged
Erigara added a commit to Erigara/iroha that referenced this issue Mar 28, 2024
@Erigara
[refactor] hyperledger-iroha#4387: Send blocks to observing peers
b16fd13 
Signed-off-by: Shanin Roman <shanin1000@yandex.ru>
VAmuzing pushed a commit to Erigara/iroha that referenced this issue Mar 28, 2024
@Erigara @VAmuzing
[refactor] hyperledger-iroha#4387: Send blocks to observing peers
7f8c79e 
Signed-off-by: Shanin Roman <shanin1000@yandex.ru>
Erigara added a commit that referenced this issue Mar 29, 2024
@Erigara
[refactor] #4387: Send blocks to observing peers
8f2481c 
Signed-off-by: Shanin Roman <shanin1000@yandex.ru>
@timofeevmd timofeevmd self-assigned this Apr 1, 2024
@timofeevmd timofeevmd added the QA-confirmed This bug is reproduced and needs a fix label Apr 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Erigara Erigara

@timofeevmd timofeevmd

Labels
Consensus This issue is related to the Sumeragi consensus iroha2-dev The re-implementation of a BFT hyperledger in RUST QA-confirmed This bug is reproduced and needs a fix
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Erigara @timofeevmd