Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix query error response with specific status code and hints. Close #1454 #1527

Merged
merged 3 commits into from
Oct 22, 2021

Conversation

s8sato
Copy link
Contributor

@s8sato s8sato commented Oct 15, 2021

1. Query Response

Description of the Change

Status and whether each step succeeded:

Status Decode & Versioning Signature Permission Find
400 N - - -
401 Y N - -
404 Y Y N -
404 Y Y Y N
200 Y Y Y Y

Asset Not Found 404

Hint and whether each object exists:

Hint Domain Account Asset Definition Asset
"domain" N - - -
"account" Y N - -
"definition" Y - N -
- Y Y Y N

Account Not Found 404

Hint and whether each object exists:

Hint Domain Account
"domain" N -
- Y N

This specification is as torii unit tests

Issue

Close #1454
Relate to #1404
Relate to #1460

Benefits

Possible Drawbacks

2. CONTRIBUTING.md Minor Fix

Description of the Change

Clarify that we use ZenHub and personal forks

@github-actions github-actions bot added the iroha2-dev The re-implementation of a BFT hyperledger in RUST label Oct 15, 2021
@codecov
Copy link

codecov bot commented Oct 15, 2021

Codecov Report

Merging #1527 (8305d6d) into iroha2-dev (51cf4a9) will increase coverage by 0.31%.
The diff coverage is 92.93%.

Impacted file tree graph

@@              Coverage Diff               @@
##           iroha2-dev    #1527      +/-   ##
==============================================
+ Coverage       76.89%   77.20%   +0.31%     
==============================================
  Files             118      118              
  Lines           18651    18968     +317     
==============================================
+ Hits            14341    14645     +304     
- Misses           4310     4323      +13     
Impacted Files Coverage Δ
core/src/smartcontracts/isi/mod.rs 75.32% <ø> (ø)
core/src/smartcontracts/isi/asset.rs 57.59% <57.14%> (+0.44%) ⬆️
core/src/torii/mod.rs 89.52% <93.87%> (-4.33%) ⬇️
core/src/smartcontracts/isi/query.rs 83.69% <100.00%> (+8.27%) ⬆️
actor/src/lib.rs 81.87% <0.00%> (ø)
core/src/sumeragi/mod.rs 91.31% <0.00%> (+0.10%) ⬆️
p2p/src/peer.rs 85.60% <0.00%> (+0.25%) ⬆️
data_model/src/expression.rs 64.43% <0.00%> (+0.26%) ⬆️
core/src/wsv.rs 93.23% <0.00%> (+0.35%) ⬆️
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 51cf4a9...8305d6d. Read the comment docs.

i1i1
i1i1 previously approved these changes Oct 16, 2021
appetrosyan
appetrosyan previously approved these changes Oct 16, 2021
@s8sato s8sato marked this pull request as draft October 18, 2021 10:29
@s8sato s8sato dismissed stale reviews from appetrosyan and i1i1 via 608b000 October 19, 2021 06:53
@appetrosyan appetrosyan linked an issue Oct 19, 2021 that may be closed by this pull request
@s8sato s8sato added the api-changes Changes in the API for client libraries label Oct 20, 2021
@s8sato s8sato force-pushed the fix/1454 branch 2 times, most recently from 9488102 to 6607a4d Compare October 21, 2021 13:00
@s8sato s8sato changed the title Return response with more specific error description #1454 Fix query error response with specific status code and hints. Close #1454 Oct 22, 2021
…yperledger-iroha#1454

Signed-off-by: s8sato <49983831+s8sato@users.noreply.github.com>
Signed-off-by: s8sato <49983831+s8sato@users.noreply.github.com>
@s8sato s8sato marked this pull request as ready for review October 22, 2021 07:46
@appetrosyan appetrosyan self-requested a review October 22, 2021 08:02
core/src/smartcontracts/isi/query.rs Show resolved Hide resolved
core/src/smartcontracts/isi/query.rs Outdated Show resolved Hide resolved
docs/source/references/api_spec.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
core/src/torii/mod.rs Outdated Show resolved Hide resolved
core/src/torii/mod.rs Show resolved Hide resolved
Signed-off-by: s8sato <49983831+s8sato@users.noreply.github.com>
@s8sato s8sato merged commit f34d0be into hyperledger-iroha:iroha2-dev Oct 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api-changes Changes in the API for client libraries iroha2-dev The re-implementation of a BFT hyperledger in RUST
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Return response with more specific error description
3 participants