-
Notifications
You must be signed in to change notification settings - Fork 279
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix query error response with specific status code and hints. Close #1454 #1527
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
s8sato
requested review from
appetrosyan,
e-ivkov,
GaroRobe,
i1i1 and
KalitaAlexey
as code owners
October 15, 2021 20:59
github-actions
bot
added
the
iroha2-dev
The re-implementation of a BFT hyperledger in RUST
label
Oct 15, 2021
Codecov Report
@@ Coverage Diff @@
## iroha2-dev #1527 +/- ##
==============================================
+ Coverage 76.89% 77.20% +0.31%
==============================================
Files 118 118
Lines 18651 18968 +317
==============================================
+ Hits 14341 14645 +304
- Misses 4310 4323 +13
Continue to review full report at Codecov.
|
i1i1
previously approved these changes
Oct 16, 2021
appetrosyan
previously approved these changes
Oct 16, 2021
s8sato
force-pushed
the
fix/1454
branch
2 times, most recently
from
October 21, 2021 13:00
9488102
to
6607a4d
Compare
s8sato
changed the title
Return response with more specific error description #1454
Fix query error response with specific status code and hints. Close #1454
Oct 22, 2021
…yperledger-iroha#1454 Signed-off-by: s8sato <49983831+s8sato@users.noreply.github.com>
Signed-off-by: s8sato <49983831+s8sato@users.noreply.github.com>
i1i1
suggested changes
Oct 22, 2021
appetrosyan
reviewed
Oct 22, 2021
Signed-off-by: s8sato <49983831+s8sato@users.noreply.github.com>
i1i1
approved these changes
Oct 22, 2021
appetrosyan
approved these changes
Oct 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
api-changes
Changes in the API for client libraries
iroha2-dev
The re-implementation of a BFT hyperledger in RUST
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1. Query Response
Description of the Change
Status and whether each step succeeded:
Asset Not Found 404
Hint and whether each object exists:
Account Not Found 404
Hint and whether each object exists:
This specification is as torii unit tests
Issue
Close #1454
Relate to #1404
Relate to #1460
Benefits
Possible Drawbacks
2.
CONTRIBUTING.md
Minor FixDescription of the Change
Clarify that we use ZenHub and personal forks