-
Notifications
You must be signed in to change notification settings - Fork 279
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[fix] #1755: Minor fixes for #1743, #1725 #1760
Conversation
Signed-off-by: s8sato <49983831+s8sato@users.noreply.github.com>
Signed-off-by: s8sato <49983831+s8sato@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Status naming is ok. As far as I understand that's what we agreed with DevOps on.
Ok, I'll revert to |
Codecov Report
@@ Coverage Diff @@
## iroha2-dev #1760 +/- ##
==============================================
+ Coverage 77.11% 77.70% +0.58%
==============================================
Files 132 132
Lines 20480 20480
==============================================
+ Hits 15794 15913 +119
+ Misses 4686 4567 -119
Continue to review full report at Codecov.
|
Ok, we discussed at the status. Changing the URL naming from |
Domain
struct changeSigned-off-by: s8sato <49983831+s8sato@users.noreply.github.com>
36c86d6
Description of the Change
Name
to exclude whitespaces #1743Domain
struct changestatus
term totelemetry
according to Remove Torii global state #1725Issue
Close #1755
Benefits
Possible Drawbacks