Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] #0000: Wasm no std fix #1865

Merged
merged 1 commit into from
Feb 3, 2022

Conversation

mversic
Copy link
Contributor

@mversic mversic commented Feb 3, 2022

Signed-off-by: Marin Veršić marin.versic101@gmail.com

Description of the Change

Issue

Benefits

Possible Drawbacks

Usage Examples or Tests [optional]

Alternate Designs [optional]

Signed-off-by: Marin Veršić <marin.versic101@gmail.com>
@github-actions github-actions bot added the iroha2-dev The re-implementation of a BFT hyperledger in RUST label Feb 3, 2022
if: always()
- name: Verify wasm smartcontracts are able to build
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a check that there is no regression, i.e. that smartcontracts can be built.
Should this check be placed somewhere else?

@appetrosyan appetrosyan changed the title [fix] Wasm no std fix [fix] #0000: Wasm no std fix Feb 3, 2022
@mversic mversic marked this pull request as ready for review February 3, 2022 11:51
@codecov
Copy link

codecov bot commented Feb 3, 2022

Codecov Report

Merging #1865 (d34569a) into iroha2-dev (e04ff9e) will increase coverage by 0.03%.
The diff coverage is 100.00%.

Impacted file tree graph

@@              Coverage Diff               @@
##           iroha2-dev    #1865      +/-   ##
==============================================
+ Coverage       78.53%   78.56%   +0.03%     
==============================================
  Files             156      156              
  Lines           21935    21935              
==============================================
+ Hits            17226    17233       +7     
+ Misses           4709     4702       -7     
Impacted Files Coverage Δ
crypto/src/lib.rs 83.02% <ø> (ø)
data_model/primitives/src/lib.rs 100.00% <ø> (ø)
data_model/primitives/src/small.rs 51.02% <ø> (ø)
data_model/src/lib.rs 68.92% <100.00%> (ø)
core/test_network/src/lib.rs 79.62% <0.00%> (-0.19%) ⬇️
p2p/src/peer.rs 82.26% <0.00%> (ø)
data_model/src/expression.rs 71.04% <0.00%> (+0.26%) ⬆️
core/src/sumeragi/network_topology.rs 96.11% <0.00%> (+0.27%) ⬆️
core/src/sumeragi/mod.rs 85.69% <0.00%> (+0.51%) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e04ff9e...d34569a. Read the comment docs.

@mversic mversic merged commit 34e7793 into hyperledger-iroha:iroha2-dev Feb 3, 2022
@mversic mversic deleted the wasm_no_std_fix branch February 3, 2022 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
iroha2-dev The re-implementation of a BFT hyperledger in RUST
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants