Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates to requirements #1964

Merged
merged 1 commit into from
Jul 26, 2022
Merged

Conversation

bhaskarvilles
Copy link
Contributor

upgrade the packages in requirements.txt

@bhaskarvilles
Copy link
Contributor Author

Can any one merge this request ?

@bhaskarvilles
Copy link
Contributor Author

Anny one ?

@appetrosyan appetrosyan temporarily deployed to test-env June 16, 2022 07:24 Inactive
@appetrosyan appetrosyan temporarily deployed to test-env June 16, 2022 07:24 Inactive
@appetrosyan appetrosyan temporarily deployed to test-env June 16, 2022 07:24 Inactive
@appetrosyan appetrosyan temporarily deployed to test-env June 16, 2022 07:24 Inactive
@appetrosyan appetrosyan enabled auto-merge (squash) June 16, 2022 07:25
@appetrosyan appetrosyan temporarily deployed to test-env June 20, 2022 09:10 Inactive
@appetrosyan appetrosyan temporarily deployed to test-env June 20, 2022 09:11 Inactive
@appetrosyan appetrosyan temporarily deployed to test-env June 20, 2022 09:11 Inactive
@appetrosyan appetrosyan temporarily deployed to test-env June 20, 2022 09:11 Inactive
@appetrosyan
Copy link
Contributor

Hello, we've been having some CI issues. They are resolved, but some of the checks are still failing. Unfortunately we can't merge as is, so you'll have to bear with us a while longer.

@bhaskarvilles
Copy link
Contributor Author

What happened to CI pipelines ?

@appetrosyan
Copy link
Contributor

Long story. But the CI runs on a custom AWS matrix, and it often drops the task which looks like a failed pipeline.

@bhaskarvilles
Copy link
Contributor Author

Migrate to Circle CI pipelines then, i see many HyperLedger Projects out using Circle CI platform.

@appetrosyan
Copy link
Contributor

Migrate to Circle CI pipelines then, i see many HyperLedger Projects out using Circle CI platform.

We'd like to, but we'd have to agree on that with hyperledger. @ryjones what do you think?

@ryjones
Copy link
Contributor

ryjones commented Jul 25, 2022

We'd like to, but we'd have to agree on that with hyperledger. @ryjones what do you think?

Please don't. We're trying to get away from Circle CI as fast as possible.

@bhaskarvilles
Copy link
Contributor Author

We'd like to, but we'd have to agree on that with hyperledger. @ryjones what do you think?

Please don't. We're trying to get away from Circle CI as fast as possible.

Why ? Maybe Azure or GitHub, GitLab will be more helpful in this.

@appetrosyan
Copy link
Contributor

Sorry didn't mean to stir up controversy.

@ryjones
Copy link
Contributor

ryjones commented Jul 25, 2022

Sorry didn't mean to stir up controversy.

No worries!

@bhaskarvilles
Copy link
Contributor Author

So my contributions will not be pushed ?

@appetrosyan
Copy link
Contributor

Oh they will, I think we can ask the DevOps to merge this without passing checks, since you clearly didn't change any code.

Signed-off-by: Bhaskar Ram <bhaskar@parrtosec.in>
Signed-off-by: Ry Jones <ry@linux.com>
@ryjones ryjones temporarily deployed to test-env July 26, 2022 01:53 Inactive
@ryjones ryjones temporarily deployed to test-env July 26, 2022 01:53 Inactive
@ryjones ryjones temporarily deployed to test-env July 26, 2022 01:53 Inactive
@ryjones ryjones temporarily deployed to test-env July 26, 2022 01:53 Inactive
@ryjones ryjones requested a review from a team July 26, 2022 01:53
@appetrosyan appetrosyan merged commit 7bae010 into hyperledger-iroha:main Jul 26, 2022
@ryjones ryjones temporarily deployed to test-env July 26, 2022 17:04 Inactive
@ryjones ryjones temporarily deployed to test-env July 26, 2022 17:05 Inactive
@ryjones ryjones temporarily deployed to test-env July 26, 2022 17:05 Inactive
@ryjones ryjones temporarily deployed to test-env July 26, 2022 17:05 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants