Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature] #1890: Introduce integration tests based on Orillion use-cases #2038

Merged
merged 5 commits into from
Apr 4, 2022

Conversation

Arjentix
Copy link
Contributor

Description of the Change

Added two new integration test for triggers.
Done only 2 of 4 desired tests, cause others are blocked by some issues. See #1890 for details

Issue

Partly closes #1890

Benefits

More tests

Possible Drawbacks

None

@github-actions github-actions bot added the iroha2-dev The re-implementation of a BFT hyperledger in RUST label Mar 30, 2022
@codecov
Copy link

codecov bot commented Mar 30, 2022

Codecov Report

Merging #2038 (59d608d) into iroha2-dev (af5c8c2) will increase coverage by 78.12%.
The diff coverage is 95.87%.

❗ Current head 59d608d differs from pull request most recent head 200ff4e. Consider uploading reports for the commit 200ff4e to get more accurate results

@@               Coverage Diff               @@
##           iroha2-dev    #2038       +/-   ##
===============================================
+ Coverage            0   78.12%   +78.12%     
===============================================
  Files               0      177      +177     
  Lines               0    24112    +24112     
===============================================
+ Hits                0    18838    +18838     
- Misses              0     5274     +5274     
Impacted Files Coverage Δ
data_model/src/events/data/filters.rs 30.74% <0.00%> (ø)
client/tests/integration/triggers/time_trigger.rs 97.29% <98.24%> (ø)
client/tests/integration/triggers/event_trigger.rs 100.00% <100.00%> (ø)
...rmissions_validators/src/public_blockchain/burn.rs 91.04% <0.00%> (ø)
logger/src/telemetry.rs 71.59% <0.00%> (ø)
client/tests/integration/asset_propagation.rs 100.00% <0.00%> (ø)
core/src/smartcontracts/isi/expression.rs 88.20% <0.00%> (ø)
core/src/sumeragi/view_change.rs 97.84% <0.00%> (ø)
...ermissions_validators/src/public_blockchain/mod.rs 95.86% <0.00%> (ø)
... and 169 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update af5c8c2...200ff4e. Read the comment docs.

appetrosyan
appetrosyan previously approved these changes Mar 31, 2022
appetrosyan
appetrosyan previously approved these changes Mar 31, 2022
Signed-off-by: Daniil Polyakov <arjentix@gmail.com>
Signed-off-by: Daniil Polyakov <arjentix@gmail.com>
Signed-off-by: Daniil Polyakov <arjentix@gmail.com>
Signed-off-by: Daniil Polyakov <arjentix@gmail.com>
Copy link
Contributor

@mversic mversic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we should be referencing xxxBox like IdentifiableBox structures in general. Those structures are there to generalize over a collection of items

client/tests/integration/triggers/time_trigger.rs Outdated Show resolved Hide resolved
client/tests/integration/triggers/event_trigger.rs Outdated Show resolved Hide resolved
client/tests/integration/triggers/event_trigger.rs Outdated Show resolved Hide resolved
client/tests/integration/triggers/time_trigger.rs Outdated Show resolved Hide resolved
client/tests/integration/triggers/time_trigger.rs Outdated Show resolved Hide resolved
Signed-off-by: Daniil Polyakov <arjentix@gmail.com>
@Arjentix Arjentix merged commit 148d247 into hyperledger-iroha:iroha2-dev Apr 4, 2022
@Arjentix Arjentix deleted the event_triggers_test branch April 4, 2022 15:09
mversic pushed a commit to mversic/iroha that referenced this pull request May 2, 2022
…n Orillion use-cases (hyperledger-iroha#2038)

Signed-off-by: Daniil Polyakov <arjentix@gmail.com>
appetrosyan pushed a commit to appetrosyan/iroha that referenced this pull request May 12, 2022
…n Orillion use-cases (hyperledger-iroha#2038)

Signed-off-by: Daniil Polyakov <arjentix@gmail.com>
appetrosyan pushed a commit to appetrosyan/iroha that referenced this pull request May 12, 2022
…n Orillion use-cases (hyperledger-iroha#2038)

Signed-off-by: Daniil Polyakov <arjentix@gmail.com>
appetrosyan pushed a commit to appetrosyan/iroha that referenced this pull request May 12, 2022
…n Orillion use-cases (hyperledger-iroha#2038)

Signed-off-by: Daniil Polyakov <arjentix@gmail.com>
mversic pushed a commit to mversic/iroha that referenced this pull request May 13, 2022
…n Orillion use-cases (hyperledger-iroha#2038)

Signed-off-by: Daniil Polyakov <arjentix@gmail.com>
mversic pushed a commit to mversic/iroha that referenced this pull request May 13, 2022
…n Orillion use-cases (hyperledger-iroha#2038)

Signed-off-by: Daniil Polyakov <arjentix@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
iroha2-dev The re-implementation of a BFT hyperledger in RUST
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants