-
Notifications
You must be signed in to change notification settings - Fork 279
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[feature] #1890: Introduce integration tests based on Orillion use-cases #2038
[feature] #1890: Introduce integration tests based on Orillion use-cases #2038
Conversation
83d272d
to
9d4d94b
Compare
Codecov Report
@@ Coverage Diff @@
## iroha2-dev #2038 +/- ##
===============================================
+ Coverage 0 78.12% +78.12%
===============================================
Files 0 177 +177
Lines 0 24112 +24112
===============================================
+ Hits 0 18838 +18838
- Misses 0 5274 +5274
Continue to review full report at Codecov.
|
9d4d94b
to
59d608d
Compare
Signed-off-by: Daniil Polyakov <arjentix@gmail.com>
Signed-off-by: Daniil Polyakov <arjentix@gmail.com>
Signed-off-by: Daniil Polyakov <arjentix@gmail.com>
Signed-off-by: Daniil Polyakov <arjentix@gmail.com>
59d608d
to
e5c4203
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think we should be referencing xxxBox
like IdentifiableBox
structures in general. Those structures are there to generalize over a collection of items
Signed-off-by: Daniil Polyakov <arjentix@gmail.com>
…n Orillion use-cases (hyperledger-iroha#2038) Signed-off-by: Daniil Polyakov <arjentix@gmail.com>
…n Orillion use-cases (hyperledger-iroha#2038) Signed-off-by: Daniil Polyakov <arjentix@gmail.com>
…n Orillion use-cases (hyperledger-iroha#2038) Signed-off-by: Daniil Polyakov <arjentix@gmail.com>
…n Orillion use-cases (hyperledger-iroha#2038) Signed-off-by: Daniil Polyakov <arjentix@gmail.com>
…n Orillion use-cases (hyperledger-iroha#2038) Signed-off-by: Daniil Polyakov <arjentix@gmail.com>
…n Orillion use-cases (hyperledger-iroha#2038) Signed-off-by: Daniil Polyakov <arjentix@gmail.com>
Description of the Change
Added two new integration test for triggers.
Done only 2 of 4 desired tests, cause others are blocked by some issues. See #1890 for details
Issue
Partly closes #1890
Benefits
More tests
Possible Drawbacks
None