[feature]: #1572: Specialized permission tokens #2156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
iroha2-dev
QuentinI
force-pushed
the
1572-permission-tokens
branch
2 times, most recently
from
5d7f510
to
91181da
Compare
QuentinI
requested review from
s8sato,
appetrosyan,
mversic,
Arjentix and
SamHSmith
as code owners
appetrosyan
reviewed
Apr 28, 2022
mversic
requested changes
Apr 28, 2022
mversic
reviewed
Apr 28, 2022
appetrosyan
reviewed
Apr 28, 2022
mversic
reviewed
Apr 28, 2022
mversic
reviewed
Apr 28, 2022
appetrosyan
previously requested changes
Apr 28, 2022
QuentinI
force-pushed
the
1572-permission-tokens
branch
3 times, most recently
from
644b51b
to
8d19521
Compare
mversic
reviewed
May 2, 2022
appetrosyan
previously approved these changes
May 2, 2022
|
@mversic, added |
mversic
previously approved these changes
May 3, 2022
s8sato
reviewed
May 3, 2022
Comment on lines
+7
to
+14
| declare_token!( | ||
| /// Can burn asset with the corresponding asset definition. | ||
| CanBurnAssetWithDefinition { | ||
| /// Asset definition id. | ||
| asset_definition_id ("asset_definition_id"): DefinitionId, | ||
| }, | ||
| "can_burn_asset_with_definition" | ||
| ); |
There was a problem hiding this comment.
Could be a derive macro:
Suggested change
| declare_token!( | |
| /// Can burn asset with the corresponding asset definition. | |
| CanBurnAssetWithDefinition { | |
| /// Asset definition id. | |
| asset_definition_id ("asset_definition_id"): DefinitionId, | |
| }, | |
| "can_burn_asset_with_definition" | |
| ); | |
| /// Can burn asset with the corresponding asset definition. | |
| #[derive(Permission)] | |
| struct CanBurnAssetWithDefinition { | |
| /// Asset definition id. | |
| asset_definition_id: DefinitionId, | |
| } |
There was a problem hiding this comment.
I chose to leave it as macro_rules because I don't have a lot of experience writing procedural macros and this one is straightforward enough to be understandable in spite of it's length IMO.
There was a problem hiding this comment.
Let's create a ticket for it in chores.
Signed-off-by: Artemii Gerasimovich <gerasimovich@soramitsu.co.jp>
Signed-off-by: Artemii Gerasimovich <gerasimovich@soramitsu.co.jp>
Signed-off-by: Quentin Inkling <mbee@protonmail.ch>
Signed-off-by: Quentin Inkling <mbee@protonmail.ch>
Signed-off-by: Quentin Inkling <mbee@protonmail.ch>
QuentinI
force-pushed
the
1572-permission-tokens
branch
from
83e096b
to
c7e6a12
Compare
appetrosyan
approved these changes
May 4, 2022
mversic
approved these changes
May 4, 2022
appetrosyan
pushed a commit
to appetrosyan/iroha
that referenced
this pull request
May 12, 2022
…erledger-iroha#2156) Signed-off-by: Artemii Gerasimovich <gerasimovich@soramitsu.co.jp>
appetrosyan
pushed a commit
to appetrosyan/iroha
that referenced
this pull request
May 12, 2022
…erledger-iroha#2156) Signed-off-by: Artemii Gerasimovich <gerasimovich@soramitsu.co.jp>
appetrosyan
pushed a commit
to appetrosyan/iroha
that referenced
this pull request
May 12, 2022
…erledger-iroha#2156) Signed-off-by: Artemii Gerasimovich <gerasimovich@soramitsu.co.jp>
appetrosyan
pushed a commit
to appetrosyan/iroha
that referenced
this pull request
May 12, 2022
…erledger-iroha#2156) Signed-off-by: Artemii Gerasimovich <gerasimovich@soramitsu.co.jp>
appetrosyan
pushed a commit
to appetrosyan/iroha
that referenced
this pull request
May 12, 2022
…erledger-iroha#2156) Signed-off-by: Artemii Gerasimovich <gerasimovich@soramitsu.co.jp>
appetrosyan
pushed a commit
to appetrosyan/iroha
that referenced
this pull request
May 12, 2022
…erledger-iroha#2156) Signed-off-by: Artemii Gerasimovich <gerasimovich@soramitsu.co.jp>
appetrosyan
pushed a commit
to appetrosyan/iroha
that referenced
this pull request
May 12, 2022
…erledger-iroha#2156) Signed-off-by: Artemii Gerasimovich <gerasimovich@soramitsu.co.jp>
appetrosyan
pushed a commit
to appetrosyan/iroha
that referenced
this pull request
May 12, 2022
…erledger-iroha#2156) Signed-off-by: Artemii Gerasimovich <gerasimovich@soramitsu.co.jp>
appetrosyan
pushed a commit
to appetrosyan/iroha
that referenced
this pull request
May 12, 2022
…erledger-iroha#2156) Signed-off-by: Artemii Gerasimovich <gerasimovich@soramitsu.co.jp>
appetrosyan
pushed a commit
to appetrosyan/iroha
that referenced
this pull request
May 12, 2022
…erledger-iroha#2156) Signed-off-by: Artemii Gerasimovich <gerasimovich@soramitsu.co.jp>
mversic
pushed a commit
to mversic/iroha
that referenced
this pull request
May 13, 2022
…erledger-iroha#2156) Signed-off-by: Artemii Gerasimovich <gerasimovich@soramitsu.co.jp>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
Created concrete types for
PermissionTokens predefined inpublic_blockchainto enable client interaction withpublic_blockchainbe less stringly-typed.Added cli util to list the new concrete token types.
Issue
Resolves #1572
Benefits
Less stringly-typed
public_blockchain.Possible Drawbacks
None?