[fix] #2150: Use rustfmt instead of cargo fmt in client/build.rs
#2187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Daniil Polyakov <arjentix@gmail.com>
Arjentix
added
iroha2-dev
Arjentix
requested review from
s8sato,
appetrosyan,
mversic,
SamHSmith,
QuentinI and
outoftardis
as code owners
Arjentix
commented
May 9, 2022
mversic
approved these changes
May 10, 2022
mversic
reviewed
May 10, 2022
| .args(&[smartcontract_path | ||
| .join("src/lib.rs") | ||
| .to_str() | ||
| .expect("Can't convert smartcontract path to str")]) |
There was a problem hiding this comment.
I would maybe recommend to use check mode with --check.
appetrosyan
approved these changes
May 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Daniil Polyakov arjentix@gmail.com
Description of the Change
cargo fmtusage was replaced byrustfmtdirectly. This is a more clean way to avoid cargo recursion problem (instead of just removingCARGO_RECURSIONenv-variable)Issue
rustfmt#2150Benefits
More legal way to solve cargo recursion problem for formatting smartcontract
Possible Drawbacks
Maybe non-trivial for multi-files smartcontracts