[feature] #2100: Add query to find all accounts with asset #2197
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Arjentix
added
Enhancement
Arjentix
requested review from
s8sato,
appetrosyan,
mversic,
SamHSmith,
QuentinI and
outoftardis
as code owners
Arjentix
force-pushed
the
find_all_accounts_with_asset
branch
from
4e2055c
to
d3a4f36
Compare
Codecov Report
@@ Coverage Diff @@
## iroha2-dev #2197 +/- ##
==============================================
- Coverage 76.57% 5.25% -71.33%
==============================================
Files 185 141 -44
Lines 26704 21653 -5051
==============================================
- Hits 20449 1137 -19312
- Misses 6255 20516 +14261
Continue to review full report at Codecov.
|
Signed-off-by: Daniil Polyakov <arjentix@gmail.com>
Signed-off-by: Daniil Polyakov <arjentix@gmail.com>
Signed-off-by: Daniil Polyakov <arjentix@gmail.com>
Signed-off-by: Daniil Polyakov <arjentix@gmail.com>
Signed-off-by: Daniil Polyakov <arjentix@gmail.com>
Signed-off-by: Daniil Polyakov <arjentix@gmail.com>
Signed-off-by: Daniil Polyakov <arjentix@gmail.com>
Signed-off-by: Daniil Polyakov <arjentix@gmail.com>
Signed-off-by: Daniil Polyakov <arjentix@gmail.com>
Signed-off-by: Daniil Polyakov <arjentix@gmail.com>
Signed-off-by: Daniil Polyakov <arjentix@gmail.com>
Arjentix
force-pushed
the
find_all_accounts_with_asset
branch
from
12dc80d
to
e4a2844
Compare
Arjentix
commented
May 12, 2022
| @@ -27,32 +27,28 @@ fn main() { | |||
| .expect("Failed to run `rustfmt` on smartcontract"); | |||
| assert!(fmt.success(), "Can't format smartcontract"); | |||
|
|
|||
| let instrumenting_coverage = if let Ok(flags) = env::var("RUSTFLAGS") { | |||
There was a problem hiding this comment.
Note from here:
Note that since Rust 1.55, RUSTFLAGS is removed from the environment; scripts should use CARGO_ENCODED_RUSTFLAGS instead.
mversic
previously approved these changes
May 13, 2022
| if let Err(error) = self.wsv.apply(block.clone()).await { | ||
| warn!(?error, %block_hash, "Failed to apply block on WSV"); | ||
| } | ||
|
|
||
| for event in Vec::<Event>::from(&block) { | ||
| trace!(?event); | ||
| drop(self.events_sender.send(event)); |
There was a problem hiding this comment.
off topic comment. I've wondered before about this drop. No big deal
mversic
reviewed
May 13, 2022
| @@ -746,14 +746,15 @@ impl<G: GenesisNetworkTrait, K: KuraTrait, W: WorldTrait, F: FaultInjection> | |||
| let block = block.commit(); | |||
| let block_hash = block.hash(); | |||
|
|
|||
| if let Err(error) = self.wsv.apply(block.clone()).await { | |||
| warn!(?error, %block_hash, "Failed to apply block on WSV"); | |||
| } | |||
There was a problem hiding this comment.
so this change fixed flakiness?
appetrosyan
reviewed
May 13, 2022
appetrosyan
reviewed
May 13, 2022
appetrosyan
previously approved these changes
May 13, 2022
appetrosyan
previously approved these changes
May 13, 2022
Signed-off-by: Daniil Polyakov <arjentix@gmail.com>
Arjentix
force-pushed
the
find_all_accounts_with_asset
branch
from
f1dc227
to
a574e4f
Compare
appetrosyan
approved these changes
May 13, 2022
mversic
approved these changes
May 13, 2022
appetrosyan
pushed a commit
to appetrosyan/iroha
that referenced
this pull request
May 13, 2022
… asset (hyperledger-iroha#2197) Signed-off-by: Daniil Polyakov <arjentix@gmail.com>
appetrosyan
pushed a commit
to appetrosyan/iroha
that referenced
this pull request
May 13, 2022
… asset (hyperledger-iroha#2197) Signed-off-by: Daniil Polyakov <arjentix@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
FindAccountsWithAssetqueryCommittedevent) were sent before actual block applying to WSVcargo flakyrunning every test for 100 times for about 4 hoursResults of running
cargo flaky(edited for readability):The 3'rd case isn't a real problem. This test just depends on a folder it runs from, we should be able to fix it probably.
The 4'th case is a compilation tests (as @mversic suggested). Not sure what does it means here.
Issue
Benefits
Possible Drawbacks
I've enabled
mint_nft_for_every_user_every_1_sectest back. I haven't runcargo flakywith it but I've run it mannually (bash script) for about 30 times and it seems to work fine. The only problem is a long execution time (~50 sec on my M1 Mac), so probably I need to ignore this test again.Usage Examples or Tests
cargo test --package iroha_client --test mod -- integration::queries::account::find_accounts_with_asset --exact --nocapture