-
Notifications
You must be signed in to change notification settings - Fork 279
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[feature] #2161: generate FFI functions for data_model
#2211
Merged
appetrosyan
merged 14 commits into
hyperledger-iroha:iroha2-dev
from
mversic:data_model_generate_ffi_fns
May 24, 2022
Merged
[feature] #2161: generate FFI functions for data_model
#2211
appetrosyan
merged 14 commits into
hyperledger-iroha:iroha2-dev
from
mversic:data_model_generate_ffi_fns
May 24, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mversic
force-pushed
the
data_model_generate_ffi_fns
branch
2 times, most recently
from
May 13, 2022 17:43
d765a26
to
500e051
Compare
mversic
force-pushed
the
data_model_generate_ffi_fns
branch
2 times, most recently
from
May 13, 2022 18:00
8c1d792
to
6afd741
Compare
Codecov Report
@@ Coverage Diff @@
## iroha2-dev #2211 +/- ##
==============================================
+ Coverage 63.89% 64.69% +0.80%
==============================================
Files 127 131 +4
Lines 23659 24589 +930
==============================================
+ Hits 15117 15909 +792
- Misses 8542 8680 +138
Continue to review full report at Codecov.
|
mversic
force-pushed
the
data_model_generate_ffi_fns
branch
2 times, most recently
from
May 13, 2022 19:38
3ed1d34
to
2a71e93
Compare
appetrosyan
added
iroha2-dev
The re-implementation of a BFT hyperledger in RUST
Enhancement
New feature or request
labels
May 17, 2022
mversic
requested review from
s8sato,
appetrosyan,
Arjentix,
SamHSmith,
QuentinI and
outoftardis
as code owners
May 17, 2022 07:59
mversic
force-pushed
the
data_model_generate_ffi_fns
branch
2 times, most recently
from
May 17, 2022 20:59
b03f55e
to
e6198a7
Compare
mversic
force-pushed
the
data_model_generate_ffi_fns
branch
3 times, most recently
from
May 19, 2022 22:55
11ef2f1
to
85586d1
Compare
Please squash this PR with care |
appetrosyan
reviewed
May 20, 2022
client/tests/integration/create_nft_for_every_user_smartcontract/Cargo.toml
Show resolved
Hide resolved
appetrosyan
reviewed
May 20, 2022
mversic
force-pushed
the
data_model_generate_ffi_fns
branch
3 times, most recently
from
May 22, 2022 13:11
d9d9c8d
to
b76050e
Compare
mversic
force-pushed
the
data_model_generate_ffi_fns
branch
from
May 23, 2022 08:41
8665315
to
e52a4a5
Compare
Signed-off-by: Marin Veršić <marin.versic101@gmail.com>
Signed-off-by: Marin Veršić <marin.versic101@gmail.com>
Signed-off-by: Marin Veršić <marin.versic101@gmail.com>
Signed-off-by: Marin Veršić <marin.versic101@gmail.com>
Signed-off-by: Marin Veršić <marin.versic101@gmail.com>
Signed-off-by: Marin Veršić <marin.versic101@gmail.com>
Signed-off-by: Marin Veršić <marin.versic101@gmail.com>
Signed-off-by: Marin Veršić <marin.versic101@gmail.com>
Signed-off-by: Marin Veršić <marin.versic101@gmail.com>
Signed-off-by: Marin Veršić <marin.versic101@gmail.com>
Signed-off-by: Marin Veršić <marin.versic101@gmail.com>
Signed-off-by: Marin Veršić <marin.versic101@gmail.com>
Signed-off-by: Marin Veršić <marin.versic101@gmail.com>
mversic
force-pushed
the
data_model_generate_ffi_fns
branch
from
May 23, 2022 08:43
e52a4a5
to
e12c399
Compare
mversic
force-pushed
the
data_model_generate_ffi_fns
branch
4 times, most recently
from
May 23, 2022 09:08
ca09f8f
to
9190960
Compare
Signed-off-by: Marin Veršić <marin.versic101@gmail.com>
mversic
force-pushed
the
data_model_generate_ffi_fns
branch
from
May 23, 2022 09:38
9190960
to
92c9f2f
Compare
s8sato
approved these changes
May 23, 2022
appetrosyan
approved these changes
May 24, 2022
pesterev
pushed a commit
to pesterev/iroha
that referenced
this pull request
May 25, 2022
…del` (hyperledger-iroha#2211) Signed-off-by: Marin Veršić <marin.versic101@gmail.com>
BAStos525
pushed a commit
to BAStos525/soramitsu-iroha
that referenced
this pull request
Jul 8, 2022
…del` (hyperledger-iroha#2211) Signed-off-by: Marin Veršić <marin.versic101@gmail.com> Signed-off-by: BAStos525 <jungle.vas@yandex.ru>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
You can find a description here: #1973
This PR introduces an
ffi
crate which holds a macroffi_bindgen
. This macro when attached to the impl block generates the equivalentffi
out of the methods listed in the impl block. The macro can also be attached to the structure definition where it integrates withgetset
to makeffi
fn equivalents of the getters/setters produced by thegetset
.Note:
FfiResult
return code. The idea is that the returned code can be used to query the errorLimitations:
Issue
Closes #2161
Benefits
Possible Drawbacks
Usage Examples or Tests [optional]
Alternate Designs [optional]
List out ffi functions manually. This is tedious and highly error prone because we're operating in the
unsafe
space