[feature] #2257: Revoke<Role> emits RoleRevoked event

[omkar-mohanty]

Description of the Change

This PR makes Revoke role emit RoleRevoked instead of Permission event.

Issue

Revoke role emits Permission events which is a misleading since roles are a collection of permission events.

Benefits

More accurate information about the user.

Possible Drawbacks

Not sure about drawbacks because I am new to the codebase.

[codecov]

Codecov Report

Merging #2264 (309b1e9) into iroha2-dev (2ba9c8f) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

@@              Coverage Diff               @@
##           iroha2-dev    #2264      +/-   ##
==============================================
- Coverage       64.67%   64.66%   -0.02%     
==============================================
  Files             131      131              
  Lines           24664    24666       +2     
==============================================
- Hits            15952    15950       -2     
- Misses           8712     8716       +4     

Impacted Files	Coverage Δ
core/src/smartcontracts/isi/account.rs	12.30% <0.00%> (ø)
data_model/src/events/data/events.rs	39.58% <0.00%> (-0.85%)	⬇️
data_model/src/events/data/filters.rs	24.23% <ø> (ø)
tools/kura_inspector/src/print.rs	95.38% <0.00%> (-0.77%)	⬇️
core/src/kura.rs	92.04% <0.00%> (-0.16%)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2ba9c8f...309b1e9. Read the comment docs.

[appetrosyan]

OK. At this point the implementation of a new event seems to be complete. @omkar-mohanty

The remaining question is that of semantics. If we merge as is, an account can lose a permission that's included in a role and event listeners that look for the permission being removed will not be notified. To me this seems like it would complicate things for trigger designers.

What I want, is for event listeners that look for PermissionAdded/Removed to also be notified if a role that contains this permission is being revoked.

This would also require a test, but I think we can handle that.

[omkar-mohanty]

I stumbled upon impl<W: WorldTrait> Execute<W> for Unregister<Role> which emits a PermissionRemoved event should I change that to RoleRevoked event?

[omkar-mohanty]

I have decided that implementing changes to the event listeners is beyond the scope of my work. As such this PR is complete.

[omkar-mohanty]

Hello maintainers I have addressed the issue in #2257 which was originally from #2007 by adding RoleRevoked event implementation. This PR still does not implement proper event processing for RoleRevoked as noted by @appetrosyan but I would like to have this PR merged as it is. Thanks for reviewing my code.

[omkar-mohanty]

For the event processing issue I have created #2280

[s8sato]

For symmetry we also need something like RoleGranted for PermissionAdded