Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature] #2125: Add FindAssetDefinitionById query #2265

Merged

Conversation

pesterev
Copy link
Contributor

@pesterev pesterev commented May 25, 2022

Description of the Change

Add a new query to get AssetDefinitionId as input and find AssetDefinition.

Issue

Resolves #2125

Benefits

New possibilities for get asset definition.

Possible Drawbacks

None

@github-actions github-actions bot added the iroha2-dev The re-implementation of a BFT hyperledger in RUST label May 25, 2022
@pesterev pesterev force-pushed the asset-definition-by-id branch 2 times, most recently from e0bcb35 to e9551e9 Compare May 25, 2022 17:42
@pesterev pesterev marked this pull request as ready for review May 25, 2022 17:48
@pesterev pesterev force-pushed the asset-definition-by-id branch 2 times, most recently from 71616a2 to 8b59efb Compare May 26, 2022 11:03
@codecov
Copy link

codecov bot commented May 26, 2022

Codecov Report

Merging #2265 (48fc783) into iroha2-dev (f04b90d) will decrease coverage by 0.06%.
The diff coverage is 5.55%.

@@              Coverage Diff               @@
##           iroha2-dev    #2265      +/-   ##
==============================================
- Coverage       64.74%   64.68%   -0.07%     
==============================================
  Files             131      131              
  Lines           24624    24659      +35     
==============================================
+ Hits            15944    15950       +6     
- Misses           8680     8709      +29     
Impacted Files Coverage Δ
client/src/client.rs 45.34% <0.00%> (-0.35%) ⬇️
core/src/smartcontracts/isi/asset.rs 33.84% <0.00%> (-0.27%) ⬇️
core/src/smartcontracts/isi/query.rs 88.92% <0.00%> (-0.28%) ⬇️
...issions_validators/src/private_blockchain/query.rs 0.00% <0.00%> (ø)
data_model/src/query.rs 24.37% <7.14%> (-0.48%) ⬇️
tools/parity_scale_decoder/src/generate_map.rs 99.42% <100.00%> (+<0.01%) ⬆️
tools/kura_inspector/src/print.rs 95.38% <0.00%> (-0.77%) ⬇️
core/src/kura.rs 92.19% <0.00%> (-0.16%) ⬇️
crypto/src/signature.rs 76.87% <0.00%> (+1.87%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f04b90d...48fc783. Read the comment docs.

@pesterev pesterev requested a review from outoftardis May 26, 2022 11:34
appetrosyan
appetrosyan previously approved these changes May 26, 2022
@s8sato s8sato self-assigned this May 26, 2022
s8sato
s8sato previously approved these changes May 26, 2022
@pesterev pesterev dismissed stale reviews from s8sato and appetrosyan via f1c33f1 May 26, 2022 14:00
@pesterev pesterev force-pushed the asset-definition-by-id branch 2 times, most recently from f1c33f1 to 2d3a8dc Compare May 26, 2022 14:04
@pesterev
Copy link
Contributor Author

pesterev commented May 26, 2022

@appetrosyan @s8sato please re-approve I forgot to add the method on client side.

appetrosyan
appetrosyan previously approved these changes May 26, 2022
s8sato
s8sato previously approved these changes May 26, 2022
Signed-off-by: Vladimir Pesterev <pesterev@pm.me>
@appetrosyan appetrosyan merged commit 1f1c8d7 into hyperledger-iroha:iroha2-dev May 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
iroha2-dev The re-implementation of a BFT hyperledger in RUST
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants