[test] #2272: Add tests for 'FindAssetDefinitionById' query

[pesterev]

Description of the Change

Add some tests for 'FindAssetDefinitionById' query.

Issue

Resolves #2272

Benefits

It tests the query.

Possible Drawbacks

None

[s8sato]

Here is also worth querying and checking the result

Suggested change

	test_client.submit_blocking(RegisterBox::new(asset_definition.clone()))?;
	test_client.submit_blocking(MintBox::new(
	test_client.submit_blocking(RegisterBox::new(asset_definition.clone()))?;
	// Here
	test_client.submit_blocking(MintBox::new(

[codecov]

Codecov Report

Merging #2273 (118dc37) into iroha2-dev (1f1c8d7) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@              Coverage Diff               @@
##           iroha2-dev    #2273      +/-   ##
==============================================
+ Coverage       64.67%   64.68%   +0.01%     
==============================================
  Files             131      131              
  Lines           24659    24664       +5     
==============================================
+ Hits            15947    15953       +6     
+ Misses           8712     8711       -1     

Impacted Files	Coverage Δ
cli/src/torii/tests.rs	94.42% <100.00%> (+0.20%)	⬆️
actor/src/deadlock.rs	98.63% <0.00%> (-1.37%)	⬇️
data_model/src/domain.rs	77.77% <0.00%> (-1.15%)	⬇️
core/src/kura.rs	92.19% <0.00%> (-0.16%)	⬇️
core/src/smartcontracts/isi/asset.rs	33.84% <0.00%> (ø)
core/src/smartcontracts/isi/query.rs	88.92% <0.00%> (ø)
actor/src/lib.rs	84.09% <0.00%> (+0.30%)	⬆️
data_model/src/asset.rs	51.88% <0.00%> (+0.41%)	⬆️
data_model/src/query.rs	24.95% <0.00%> (+0.57%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1f1c8d7...118dc37. Read the comment docs.

[appetrosyan]

Since this is not what I asked you to do, I would like to know why you decided not to add the query to an existing test.

[pesterev]

OK, now I got you. So I'm going to move this test into the closest module (account.rs) like this:

    // Registering accounts
    let register_accounts = accounts
        .iter()
        .skip(1) // Alice has already been registered in genesis
        .cloned()
        .map(|account_id| RegisterBox::new(Account::new(account_id, [])).into())
        .collect::<Vec<_>>();
    test_client.submit_all_blocking(register_accounts)?;

   // HERE
===>  let received_asset_definition = test_client.request(client::asset::definition_by_id(definition_id))?;
===>  assert_eq!(received_asset_definition, asset_definition.build());

    let mint_asset = accounts
        .iter()
        .cloned()
        .map(|account_id| <Asset as Identifiable>::Id::new(definition_id.clone(), account_id))
        .map(|asset_id| MintBox::new(1_u32, asset_id).into())
        .collect::<Vec<_>>();
    test_client.submit_all_blocking(mint_asset)?;

   // HERE AFTER MINTING
===>   let received_asset_definition = test_client.request(client::asset::definition_by_id(definition_id))?;
===>   assert_eq!(received_asset_definition, asset_definition.build());

    let accounts = HashSet::from(accounts);

[s8sato]

I now realize that this PR only needs to replace FindAllAssetsDefinitions with FindAssetDefinitionById in this Torii unit test

[pesterev]

Yeah seems this test needs to replace but its only on the server-side. I also added a new client-side method so I think it also should be tested.

stale

[pesterev]

@appetrosyan I've removed asset_definition.rs module and moved the test into an existing test in account.rs module.

@s8sato I've replaced FindAllAssetsDefinitions with FindAssetDefinitionById in find_asset_definition.