[refactor] #2323: Enhance kura init error message #2329
Merged
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ilchu
requested review from
s8sato,
appetrosyan,
mversic,
Arjentix,
SamHSmith,
QuentinI and
outoftardis
as code owners
github-actions
bot
added
the
iroha2-dev
outoftardis
reviewed
Jun 7, 2022
Codecov Report
@@ Coverage Diff @@
## iroha2-dev #2329 +/- ##
==============================================
+ Coverage 64.67% 65.39% +0.72%
==============================================
Files 131 133 +2
Lines 24664 24803 +139
==============================================
+ Hits 15952 16221 +269
+ Misses 8712 8582 -130
Continue to review full report at Codecov.
|
Signed-off-by: Ilia Churin <churin.ilya@gmail.com>
outoftardis
approved these changes
Jun 7, 2022
appetrosyan
approved these changes
Jun 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Ilia Churin churin.ilya@gmail.com
Description of the Change
A slightly altered error message for cases when
kurainitialization goes wrong.Issue
Resolves #2323.
Benefits
Suggests a makeshift solution to Iroha users.
Possible Drawbacks
The message could actually be somewhat misleading. If there is a network being run by
docker composeand only one of the peers has faulty data, simply restarting it wouldn't help as it will keep crashing over and over. Maybe I'm missing out on some technique, but so far the only viable solution for me was rebuilding the network, so I made sure the message reflects that.