-
Notifications
You must be signed in to change notification settings - Fork 279
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[feature] #2899: Add multi-instructions subcommand into client_cli
#2918
[feature] #2899: Add multi-instructions subcommand into client_cli
#2918
Conversation
5e8bcd3
to
c678b36
Compare
client_cli
Codecov Report
@@ Coverage Diff @@
## iroha2-dev #2918 +/- ##
==============================================
- Coverage 67.61% 62.18% -5.44%
==============================================
Files 140 168 +28
Lines 26173 29958 +3785
==============================================
+ Hits 17696 18628 +932
- Misses 8477 11330 +2853
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Short and sweet. Excellent. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool! Probably need to update docs too.
c678b36
to
009477a
Compare
…nto 'client_cli' Signed-off-by: Vladimir Pesterev <pesterev@pm.me>
009477a
to
5591db0
Compare
Signed-off-by: Vladimir Pesterev pesterev@pm.me
Description of the Change
More details about the suggestion you can find here.
I spent some time trying to reuse
GenesisTransaction
s format (configs/peer/genesis.json
) but it's a bad way cause demand depends oniroha_core
and a lot of boilerplate code being converted. But I noticed that we can just useSerialize/Deserialize
which already implemented forInstruction
s and use those traits to represent instructions as JSON. As a result, I got a way to make a more convenient and simple implementation of this command.Issue
Closes #2899
Benefits
Submit multiple instructions using one command
Possible Drawbacks
None
Usage Examples or Tests
Save these instructions into a file:
And then pass to
client_cli
like this: