-
Notifications
You must be signed in to change notification settings - Fork 279
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[feature] #2993: enable all references in FFI #2994
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mversic
requested review from
s8sato,
appetrosyan,
Arjentix,
SamHSmith,
QuentinI,
outoftardis,
ilchu,
pesterev and
Erigara
as code owners
December 7, 2022 09:32
github-actions
bot
added
the
iroha2-dev
The re-implementation of a BFT hyperledger in RUST
label
Dec 7, 2022
mversic
force-pushed
the
ffi_references
branch
from
December 7, 2022 12:56
76f2a30
to
07804f5
Compare
Erigara
reviewed
Dec 7, 2022
mversic
force-pushed
the
ffi_references
branch
from
December 8, 2022 21:51
07804f5
to
e118788
Compare
Codecov Report
@@ Coverage Diff @@
## iroha2-dev #2994 +/- ##
==============================================
- Coverage 67.61% 62.37% -5.24%
==============================================
Files 140 169 +29
Lines 26173 31176 +5003
==============================================
+ Hits 17696 19446 +1750
- Misses 8477 11730 +3253
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
mversic
force-pushed
the
ffi_references
branch
from
December 8, 2022 21:59
e118788
to
58a8b94
Compare
mversic
force-pushed
the
ffi_references
branch
from
December 9, 2022 08:31
58a8b94
to
6d5fe8f
Compare
mversic
commented
Dec 9, 2022
mversic
force-pushed
the
ffi_references
branch
2 times, most recently
from
December 9, 2022 10:19
522bde0
to
e007a12
Compare
mversic
commented
Dec 9, 2022
Erigara
previously approved these changes
Dec 9, 2022
mversic
force-pushed
the
ffi_references
branch
from
December 12, 2022 13:07
e007a12
to
97b4eac
Compare
mversic
force-pushed
the
ffi_references
branch
from
December 12, 2022 13:33
97b4eac
to
d16b64e
Compare
mversic
force-pushed
the
ffi_references
branch
from
December 12, 2022 13:47
d16b64e
to
db0e1f2
Compare
mversic
force-pushed
the
ffi_references
branch
4 times, most recently
from
December 14, 2022 10:23
6a1bc26
to
7f135cf
Compare
appetrosyan
previously approved these changes
Dec 14, 2022
mversic
force-pushed
the
ffi_references
branch
3 times, most recently
from
December 14, 2022 19:42
516652e
to
4dbbe03
Compare
mversic
force-pushed
the
ffi_references
branch
from
December 15, 2022 08:06
4dbbe03
to
95d023d
Compare
mversic
force-pushed
the
ffi_references
branch
2 times, most recently
from
December 16, 2022 09:17
93e9b1f
to
c4dc980
Compare
appetrosyan
reviewed
Dec 16, 2022
mversic
commented
Dec 16, 2022
appetrosyan
previously approved these changes
Dec 16, 2022
Signed-off-by: Marin Veršić <marin.versic101@gmail.com>
mversic
force-pushed
the
ffi_references
branch
from
December 16, 2022 09:32
c4dc980
to
24a2978
Compare
appetrosyan
approved these changes
Dec 16, 2022
Erigara
approved these changes
Dec 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Marin Veršić marin.versic101@gmail.com
Description of the Change
NonTransmute
toCloned
webassembly_test
Hash
transparentIssue
Closes #2854 #2993
Benefits
Possible Drawbacks
Usage Examples or Tests [optional]
Alternate Designs [optional]