Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature] #2993: enable all references in FFI #2994

Merged
merged 1 commit into from
Dec 16, 2022

Conversation

mversic
Copy link
Contributor

@mversic mversic commented Dec 7, 2022

Signed-off-by: Marin Veršić marin.versic101@gmail.com

Description of the Change

  • Opening this PR as a precursor to the FFI wrapper PR
  • rename NonTransmute to Cloned
  • annotate tests with webassembly_test
  • make Hash transparent

Issue

Closes #2854 #2993

Benefits

Possible Drawbacks

Usage Examples or Tests [optional]

Alternate Designs [optional]

@codecov
Copy link

codecov bot commented Dec 8, 2022

Codecov Report

Merging #2994 (24a2978) into iroha2-dev (a16d9c3) will decrease coverage by 5.23%.
The diff coverage is 64.31%.

@@              Coverage Diff               @@
##           iroha2-dev    #2994      +/-   ##
==============================================
- Coverage       67.61%   62.37%   -5.24%     
==============================================
  Files             140      169      +29     
  Lines           26173    31176    +5003     
==============================================
+ Hits            17696    19446    +1750     
- Misses           8477    11730    +3253     
Impacted Files Coverage Δ
actor/src/actor_id.rs 90.00% <ø> (ø)
actor/src/deadlock.rs 85.93% <ø> (-14.07%) ⬇️
cli/derive/src/lib.rs 92.30% <ø> (+17.58%) ⬆️
cli/src/event.rs 0.00% <0.00%> (-41.87%) ⬇️
cli/src/main.rs 1.09% <0.00%> (-0.26%) ⬇️
cli/src/stream.rs 0.00% <0.00%> (-81.40%) ⬇️
client/src/http.rs 51.16% <0.00%> (+3.33%) ⬆️
client/src/http_default.rs 40.17% <0.00%> (-20.01%) ⬇️
client_cli/src/main.rs 0.25% <0.00%> (-0.01%) ⬇️
config/base/src/runtime_upgrades.rs 49.42% <0.00%> (ø)
... and 224 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@mversic mversic force-pushed the ffi_references branch 2 times, most recently from 522bde0 to e007a12 Compare December 9, 2022 10:19
crypto/src/hash.rs Outdated Show resolved Hide resolved
Erigara
Erigara previously approved these changes Dec 9, 2022
crypto/src/hash.rs Outdated Show resolved Hide resolved
appetrosyan
appetrosyan previously approved these changes Dec 14, 2022
ffi/src/repr_c.rs Show resolved Hide resolved
ffi/src/repr_c.rs Outdated Show resolved Hide resolved
crypto/src/hash.rs Outdated Show resolved Hide resolved
appetrosyan
appetrosyan previously approved these changes Dec 16, 2022
Signed-off-by: Marin Veršić <marin.versic101@gmail.com>
@mversic mversic merged commit 5c1d674 into hyperledger-iroha:iroha2-dev Dec 16, 2022
@mversic mversic deleted the ffi_references branch December 16, 2022 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
iroha2-dev The re-implementation of a BFT hyperledger in RUST
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants