-
Notifications
You must be signed in to change notification settings - Fork 279
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[feature] #2995: Soft fork detection #2996
[feature] #2995: Soft fork detection #2996
Conversation
Codecov Report
@@ Coverage Diff @@
## iroha2-dev #2996 +/- ##
==============================================
- Coverage 67.61% 62.31% -5.30%
==============================================
Files 140 169 +29
Lines 26173 31167 +4994
==============================================
+ Hits 17696 19421 +1725
- Misses 8477 11746 +3269
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well done, we can merge this as is, or you can include the vote counting special case I mentioned.
I recommend we merge this and then you can do the vote thing as a seperate ticket.
3be87a8
to
3d6136a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with some nitpicks
Signed-off-by: Shanin Roman <shanin1000@yandex.ru>
62f4ecd
to
92aa9b3
Compare
Description of the Change
Add mechanism to detect soft forks during block sync.
Issue
Closes #2995.
Benefits
Easier to debug problems with inconsistent blockchain state.
Possible Drawbacks
Added complexity to sumeragi.