Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature] #2995: Soft fork detection #2996

Merged
merged 1 commit into from
Dec 12, 2022

Conversation

Erigara
Copy link
Contributor

@Erigara Erigara commented Dec 7, 2022

Description of the Change

Add mechanism to detect soft forks during block sync.

Issue

Closes #2995.

Benefits

Easier to debug problems with inconsistent blockchain state.

Possible Drawbacks

Added complexity to sumeragi.

@Erigara Erigara self-assigned this Dec 7, 2022
@github-actions github-actions bot added the iroha2-dev The re-implementation of a BFT hyperledger in RUST label Dec 7, 2022
@Erigara Erigara added the Consensus This issue is related to the Sumeragi consensus label Dec 7, 2022
@codecov
Copy link

codecov bot commented Dec 7, 2022

Codecov Report

Merging #2996 (92aa9b3) into iroha2-dev (a16d9c3) will decrease coverage by 5.29%.
The diff coverage is 70.29%.

@@              Coverage Diff               @@
##           iroha2-dev    #2996      +/-   ##
==============================================
- Coverage       67.61%   62.31%   -5.30%     
==============================================
  Files             140      169      +29     
  Lines           26173    31167    +4994     
==============================================
+ Hits            17696    19421    +1725     
- Misses           8477    11746    +3269     
Impacted Files Coverage Δ
actor/src/actor_id.rs 90.00% <ø> (ø)
actor/src/deadlock.rs 85.93% <ø> (-14.07%) ⬇️
cli/derive/src/lib.rs 92.30% <ø> (+17.58%) ⬆️
cli/src/event.rs 0.00% <0.00%> (-41.87%) ⬇️
cli/src/main.rs 1.09% <0.00%> (-0.26%) ⬇️
cli/src/stream.rs 0.00% <ø> (-81.40%) ⬇️
client/src/http.rs 51.16% <0.00%> (+3.33%) ⬆️
client/src/http_default.rs 40.17% <0.00%> (-20.01%) ⬇️
client_cli/src/main.rs 0.25% <0.00%> (-0.01%) ⬇️
config/base/src/runtime_upgrades.rs 49.42% <0.00%> (ø)
... and 225 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

SamHSmith
SamHSmith previously approved these changes Dec 7, 2022
Copy link
Contributor

@SamHSmith SamHSmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done, we can merge this as is, or you can include the vote counting special case I mentioned.

I recommend we merge this and then you can do the vote thing as a seperate ticket.

QuentinI
QuentinI previously approved these changes Dec 12, 2022
Copy link
Contributor

@QuentinI QuentinI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with some nitpicks

core/src/block.rs Outdated Show resolved Hide resolved
core/src/sumeragi/mod.rs Outdated Show resolved Hide resolved
SamHSmith
SamHSmith previously approved these changes Dec 12, 2022
QuentinI
QuentinI previously approved these changes Dec 12, 2022
Signed-off-by: Shanin Roman <shanin1000@yandex.ru>
@Erigara Erigara merged commit b741a4c into hyperledger-iroha:iroha2-dev Dec 12, 2022
@Erigara Erigara deleted the detect_soft_fork branch December 12, 2022 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Consensus This issue is related to the Sumeragi consensus iroha2-dev The re-implementation of a BFT hyperledger in RUST
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants