Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] #3360: Fix tps benchmark #3361

Merged
merged 2 commits into from
Apr 10, 2023

Conversation

Erigara
Copy link
Contributor

@Erigara Erigara commented Apr 10, 2023

Description

  • fix benchmark
  • add missing ports

Linked issue

Closes #3360

Benefits

  • benchmark works
  • tests work more stable

Checklist

  • I've read CONTRIBUTING.md
  • I've used the standard signed-off commit format (or will squash just before merging)
  • All applicable CI checks pass (or I promised to make them pass later)
  • (optional) I've written unit tests for the code changes
  • I replied to all comments after code review, marking all implemented changes with thumbs up

Signed-off-by: Shanin Roman <shanin1000@yandex.ru>
Signed-off-by: Shanin Roman <shanin1000@yandex.ru>
@Erigara Erigara added Bug Something isn't working iroha2-dev The re-implementation of a BFT hyperledger in RUST Refactor Improvement to overall code quality labels Apr 10, 2023
@Erigara Erigara requested a review from s8sato as a code owner April 10, 2023 08:47
@Erigara Erigara self-assigned this Apr 10, 2023
@codecov
Copy link

codecov bot commented Apr 10, 2023

Codecov Report

Merging #3361 (79ef971) into iroha2-dev (a4d5c9f) will decrease coverage by 7.94%.
The diff coverage is 42.67%.

@@              Coverage Diff               @@
##           iroha2-dev    #3361      +/-   ##
==============================================
- Coverage       62.33%   54.40%   -7.94%     
==============================================
  Files             169      162       -7     
  Lines           31218    31339     +121     
==============================================
- Hits            19459    17049    -2410     
- Misses          11759    14290    +2531     
Impacted Files Coverage Δ
cli/src/lib.rs 0.28% <0.00%> (-69.15%) ⬇️
cli/src/main.rs 0.85% <0.00%> (-0.25%) ⬇️
cli/src/samples.rs 0.00% <ø> (-61.85%) ⬇️
cli/src/torii/mod.rs 0.00% <0.00%> (-27.66%) ⬇️
cli/src/torii/routing.rs 0.00% <0.00%> (-57.11%) ⬇️
cli/src/torii/utils.rs 0.00% <0.00%> (-84.85%) ⬇️
client/src/http_default.rs 0.00% <0.00%> (-38.94%) ⬇️
client_cli/src/main.rs 0.25% <0.00%> (+<0.01%) ⬆️
config/base/src/lib.rs 91.57% <ø> (+55.21%) ⬆️
config/src/lib.rs 33.33% <ø> (ø)
... and 105 more

... and 39 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@appetrosyan
Copy link
Contributor

@BAStos525 We should set up a CI check for benchmarks.

@Erigara Erigara merged commit 9dc702f into hyperledger-iroha:iroha2-dev Apr 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working iroha2-dev The re-implementation of a BFT hyperledger in RUST Refactor Improvement to overall code quality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants