-
Notifications
You must be signed in to change notification settings - Fork 279
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[feature] #3168: Provide genesis validator in separate file #3434
Merged
Erigara
merged 1 commit into
hyperledger-iroha:iroha2-dev
from
Erigara:load_validator_from_file
May 2, 2023
Merged
[feature] #3168: Provide genesis validator in separate file #3434
Erigara
merged 1 commit into
hyperledger-iroha:iroha2-dev
from
Erigara:load_validator_from_file
May 2, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Erigara
requested review from
s8sato,
appetrosyan,
mversic,
Arjentix,
SamHSmith,
QuentinI,
outoftardis,
ilchu,
pesterev and
0x009922
as code owners
April 28, 2023 13:20
Erigara
force-pushed
the
load_validator_from_file
branch
from
April 28, 2023 13:25
3ffa580
to
1330dde
Compare
Codecov Report
@@ Coverage Diff @@
## iroha2-dev #3434 +/- ##
==============================================
- Coverage 62.33% 56.37% -5.97%
==============================================
Files 169 158 -11
Lines 31218 29755 -1463
==============================================
- Hits 19459 16773 -2686
- Misses 11759 12982 +1223
|
Erigara
force-pushed
the
load_validator_from_file
branch
from
April 28, 2023 13:33
1330dde
to
00b28f7
Compare
mversic
reviewed
Apr 28, 2023
mversic
reviewed
Apr 28, 2023
mversic
reviewed
Apr 28, 2023
mversic
reviewed
Apr 28, 2023
mversic
previously approved these changes
Apr 28, 2023
appetrosyan
reviewed
Apr 30, 2023
appetrosyan
previously approved these changes
Apr 30, 2023
Erigara
force-pushed
the
load_validator_from_file
branch
from
May 2, 2023 07:43
00b28f7
to
e523354
Compare
mversic
previously approved these changes
May 2, 2023
…te file Signed-off-by: Shanin Roman <shanin1000@yandex.ru>
Erigara
force-pushed
the
load_validator_from_file
branch
from
May 2, 2023 08:11
e523354
to
4b08df8
Compare
mversic
reviewed
May 2, 2023
mversic
approved these changes
May 2, 2023
mversic
reviewed
May 2, 2023
appetrosyan
approved these changes
May 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add ability to provide validator in separate file not inlined in genesis.
Linked issue
Closes #3168
Benefits
Genesis isn't overloaded with inlined validator.
Checklist
CONTRIBUTING.md