Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature] #3168: Provide genesis validator in separate file #3434

Merged

Conversation

Erigara
Copy link
Contributor

@Erigara Erigara commented Apr 28, 2023

Description

Add ability to provide validator in separate file not inlined in genesis.

Linked issue

Closes #3168

Benefits

Genesis isn't overloaded with inlined validator.

Checklist

  • I've read CONTRIBUTING.md
  • I've used the standard signed-off commit format (or will squash just before merging)
  • All applicable CI checks pass (or I promised to make them pass later)
  • (optional) I've written unit tests for the code changes
  • I replied to all comments after code review, marking all implemented changes with thumbs up

@Erigara Erigara added the iroha2-dev The re-implementation of a BFT hyperledger in RUST label Apr 28, 2023
@Erigara Erigara self-assigned this Apr 28, 2023
@codecov
Copy link

codecov bot commented Apr 28, 2023

Codecov Report

Merging #3434 (4b08df8) into iroha2-dev (a4d5c9f) will decrease coverage by 5.97%.
The diff coverage is 46.52%.

@@              Coverage Diff               @@
##           iroha2-dev    #3434      +/-   ##
==============================================
- Coverage       62.33%   56.37%   -5.97%     
==============================================
  Files             169      158      -11     
  Lines           31218    29755    -1463     
==============================================
- Hits            19459    16773    -2686     
- Misses          11759    12982    +1223     
Impacted Files Coverage Δ
cli/src/lib.rs 0.58% <0.00%> (-68.85%) ⬇️
cli/src/main.rs 0.66% <0.00%> (-0.44%) ⬇️
cli/src/samples.rs 0.00% <0.00%> (-61.85%) ⬇️
cli/src/style.rs 0.00% <0.00%> (ø)
cli/src/torii/mod.rs 0.00% <0.00%> (-27.66%) ⬇️
cli/src/torii/routing.rs 0.00% <0.00%> (-57.11%) ⬇️
cli/src/torii/utils.rs 0.00% <0.00%> (-84.85%) ⬇️
client/src/http_default.rs 0.00% <0.00%> (-38.94%) ⬇️
client_cli/src/main.rs 0.25% <0.00%> (+<0.01%) ⬆️
config/base/src/lib.rs 95.08% <ø> (+58.71%) ⬆️
... and 100 more

... and 51 files with indirect coverage changes

tools/kagami/README.md Outdated Show resolved Hide resolved
@mversic mversic self-requested a review April 28, 2023 21:48
mversic
mversic previously approved these changes Apr 28, 2023
genesis/Cargo.toml Outdated Show resolved Hide resolved
appetrosyan
appetrosyan previously approved these changes Apr 30, 2023
mversic
mversic previously approved these changes May 2, 2023
…te file

Signed-off-by: Shanin Roman <shanin1000@yandex.ru>
@Erigara Erigara merged commit 6daae99 into hyperledger-iroha:iroha2-dev May 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
iroha2-dev The re-implementation of a BFT hyperledger in RUST
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants