Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[refactor] #3640: place permission tokens in a separate module #3940

Merged

Conversation

mversic
Copy link
Contributor

@mversic mversic commented Oct 2, 2023

Description

  • moved all tokens to a separate module
    I'll still explore the way of how to make them in a separate crate
  • optimized permission execution

Linked issue

Closes #3640

Benefits

Checklist

  • I've read CONTRIBUTING.md
  • I've used the standard signed-off commit format (or will squash just before merging)
  • All applicable CI checks pass (or I promised to make them pass later)
  • (optional) I've written unit tests for the code changes
  • I replied to all comments after code review, marking all implemented changes with thumbs up

@github-actions github-actions bot added the iroha2-dev The re-implementation of a BFT hyperledger in RUST label Oct 2, 2023
@coveralls
Copy link

coveralls commented Oct 2, 2023

Pull Request Test Coverage Report for Build 6665274219

  • 13 of 341 (3.81%) changed or added relevant lines in 2 files are covered.
  • 6930 unchanged lines in 129 files lost coverage.
  • Overall coverage decreased (-3.6%) to 55.841%

Changes Missing Coverage Covered Lines Changed/Added Lines %
smart_contract/executor/src/default.rs 0 55 0.0%
smart_contract/executor/src/default/tokens.rs 13 286 4.55%
Files with Coverage Reduction New Missed Lines %
client/src/lib.rs 1 0.0%
config/base/derive/src/view.rs 1 99.37%
config/src/block_sync.rs 1 95.0%
config/src/network.rs 1 93.75%
config/src/torii.rs 1 96.0%
config/src/wasm.rs 1 87.5%
core/src/smartcontracts/isi/block.rs 1 87.5%
config/src/kura.rs 2 79.41%
config/src/lib.rs 2 0.0%
ffi/src/option.rs 2 71.43%
Totals Coverage Status
Change from base Build 5423219773: -3.6%
Covered Lines: 22068
Relevant Lines: 39519

💛 - Coveralls

Erigara
Erigara previously approved these changes Oct 2, 2023
@mversic mversic force-pushed the permission_tokens_crate branch 5 times, most recently from 8bc0742 to 6369ed8 Compare October 9, 2023 12:08
Erigara
Erigara previously approved these changes Oct 10, 2023
@mversic mversic force-pushed the permission_tokens_crate branch 2 times, most recently from 9e9de4a to a8341ad Compare October 11, 2023 13:30
@mversic mversic force-pushed the permission_tokens_crate branch 2 times, most recently from 7f3f74e to e710cf9 Compare October 11, 2023 14:04
smart_contract/executor/src/tokens.rs Outdated Show resolved Hide resolved
smart_contract/executor/src/tokens.rs Outdated Show resolved Hide resolved
smart_contract/executor/src/tokens.rs Outdated Show resolved Hide resolved
@6r1d 6r1d force-pushed the iroha2-dev branch 2 times, most recently from 66fec94 to bf90a7d Compare October 17, 2023 11:50
@mversic mversic force-pushed the permission_tokens_crate branch 6 times, most recently from af77e03 to 8a02dcb Compare October 27, 2023 08:46
…ate module

Signed-off-by: Marin Veršić <marin.versic101@gmail.com>
@mversic mversic merged commit 9f7530d into hyperledger-iroha:iroha2-dev Oct 31, 2023
10 checks passed
@mversic mversic deleted the permission_tokens_crate branch October 31, 2023 07:08
mversic added a commit to mversic/iroha that referenced this pull request Feb 29, 2024
…ate module (hyperledger-iroha#3940)

Signed-off-by: Marin Veršić <marin.versic101@gmail.com>
mversic added a commit to mversic/iroha that referenced this pull request Feb 29, 2024
…ate module (hyperledger-iroha#3940)

Signed-off-by: Marin Veršić <marin.versic101@gmail.com>
mversic added a commit that referenced this pull request Mar 1, 2024
…4334)

* [refactor] #3640: place permission tokens in a separate module (#3940)

Signed-off-by: Marin Veršić <marin.versic101@gmail.com>

* [fix] #3962: Revoke associated tokens on entity unregistretration

Signed-off-by: Shanin Roman <shanin1000@yandex.ru>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
iroha2-dev The re-implementation of a BFT hyperledger in RUST
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants