-
Notifications
You must be signed in to change notification settings - Fork 279
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[feature] #3871: Register<AssetDefinition>
permissions
#4049
Merged
mversic
merged 1 commit into
hyperledger-iroha:iroha2-dev
from
ilchu:3871-asset-definition-permissions
Jan 19, 2024
Merged
[feature] #3871: Register<AssetDefinition>
permissions
#4049
mversic
merged 1 commit into
hyperledger-iroha:iroha2-dev
from
ilchu:3871-asset-definition-permissions
Jan 19, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ilchu
requested review from
s8sato,
mversic,
Arjentix,
SamHSmith,
QuentinI,
outoftardis,
pesterev,
Erigara,
0x009922 and
DCNick3
as code owners
November 13, 2023 12:10
github-actions
bot
added
the
iroha2-dev
The re-implementation of a BFT hyperledger in RUST
label
Nov 13, 2023
Pull Request Test Coverage Report for Build 7163917976
💛 - Coveralls |
Arjentix
reviewed
Nov 13, 2023
Erigara
previously approved these changes
Nov 14, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
5 tasks
ilchu
force-pushed
the
3871-asset-definition-permissions
branch
2 times, most recently
from
November 18, 2023 09:05
e65d631
to
78daec4
Compare
Also there is an unrelated commit in this PR. You should probably remove it |
ilchu
force-pushed
the
3871-asset-definition-permissions
branch
2 times, most recently
from
November 27, 2023 07:41
be4eda2
to
6ccc149
Compare
ilchu
force-pushed
the
3871-asset-definition-permissions
branch
4 times, most recently
from
December 4, 2023 08:25
52e35bd
to
198d083
Compare
mversic
force-pushed
the
3871-asset-definition-permissions
branch
3 times, most recently
from
January 18, 2024 08:06
16b25d0
to
7364565
Compare
mversic
previously approved these changes
Jan 18, 2024
mversic
force-pushed
the
3871-asset-definition-permissions
branch
6 times, most recently
from
January 18, 2024 12:38
93fa6a5
to
4365ae0
Compare
mversic
previously approved these changes
Jan 18, 2024
mversic
force-pushed
the
3871-asset-definition-permissions
branch
from
January 18, 2024 12:50
4365ae0
to
5a07f25
Compare
mversic
previously approved these changes
Jan 18, 2024
mversic
force-pushed
the
3871-asset-definition-permissions
branch
2 times, most recently
from
January 18, 2024 13:08
55fd661
to
941ec03
Compare
Arjentix
suggested changes
Jan 18, 2024
mversic
force-pushed
the
3871-asset-definition-permissions
branch
from
January 18, 2024 14:06
941ec03
to
ede479e
Compare
…gister<Account>`/`Mint<Asset>` permissions Signed-off-by: Ilia Churin <churin.ilya@gmail.com> Signed-off-by: Marin Veršić <marin.versic101@gmail.com>
mversic
force-pushed
the
3871-asset-definition-permissions
branch
from
January 18, 2024 14:21
ede479e
to
3e22684
Compare
mversic
approved these changes
Jan 19, 2024
Arjentix
approved these changes
Jan 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
With this change, having a permission token is required to register
AssetDefinition
s in domains for accounts besides the domain owner.CanMintUserAsset
permission tokenCanRegisterAccountInDomain
permission tokenCanRegisterAssetDefinitionInDomain
permission_tokenCanXXXAssetsWithDefinition
toCanXXXAssetWithDefinition
Grant/Revoke::permission_token
toGrant/Revoke::permission
Linked issue
Closes #3871.
Benefits
More granular control over roles in permissioned blockchain.
Checklist
CONTRIBUTING.md