Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature] #4060: add support for boxed slices in FFI #4062

Merged
merged 1 commit into from
Nov 21, 2023

Conversation

mversic
Copy link
Contributor

@mversic mversic commented Nov 20, 2023

Description

Linked issue

Closes #4060

Benefits

Checklist

  • I've read CONTRIBUTING.md
  • I've used the standard signed-off commit format (or will squash just before merging)
  • All applicable CI checks pass (or I promised to make them pass later)
  • (optional) I've written unit tests for the code changes
  • I replied to all comments after code review, marking all implemented changes with thumbs up

@github-actions github-actions bot added the iroha2-dev The re-implementation of a BFT hyperledger in RUST label Nov 20, 2023
@DCNick3 DCNick3 self-assigned this Nov 20, 2023
@coveralls
Copy link

coveralls commented Nov 20, 2023

Pull Request Test Coverage Report for Build 6942300741

  • 34 of 94 (36.17%) changed or added relevant lines in 3 files are covered.
  • 6810 unchanged lines in 127 files lost coverage.
  • Overall coverage decreased (-3.1%) to 56.322%

Changes Missing Coverage Covered Lines Changed/Added Lines %
ffi/src/repr_c.rs 24 84 28.57%
Files with Coverage Reduction New Missed Lines %
config/base/derive/src/view.rs 1 99.37%
config/src/block_sync.rs 1 95.0%
config/src/network.rs 1 93.75%
config/src/torii.rs 1 95.45%
config/src/wasm.rs 1 87.5%
core/src/smartcontracts/isi/block.rs 1 87.5%
config/src/kura.rs 2 79.41%
config/src/lib.rs 2 0.0%
ffi/src/option.rs 2 71.43%
config/src/genesis.rs 3 72.92%
Totals Coverage Status
Change from base Build 5423219773: -3.1%
Covered Lines: 23002
Relevant Lines: 40840

💛 - Coveralls

Cargo.toml Show resolved Hide resolved
ffi/src/repr_c.rs Show resolved Hide resolved
ffi/src/repr_c.rs Outdated Show resolved Hide resolved
DCNick3
DCNick3 previously approved these changes Nov 21, 2023
ffi/src/slice.rs Outdated Show resolved Hide resolved
Signed-off-by: Marin Veršić <marin.versic101@gmail.com>
@mversic mversic merged commit 73f677b into hyperledger-iroha:iroha2-dev Nov 21, 2023
11 checks passed
@mversic mversic deleted the ffi_unsized_types branch November 21, 2023 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
iroha2-dev The re-implementation of a BFT hyperledger in RUST
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants