[feature] #3974: Add subcommands into iroha_client_cli to edit domain metadata #4175
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Vladimir Pesterev <8786922+pesterev@users.noreply.github.com>
VAmuzing
requested review from
s8sato,
mversic,
Arjentix,
SamHSmith,
QuentinI,
outoftardis,
ilchu,
pesterev,
Erigara,
0x009922 and
DCNick3
as code owners
github-actions
bot
added
the
iroha2-dev
Signed-off-by: VAmuzing <amuzik95@gmail.com> Signed-off-by: VAmuzing <amuzik95@gmail.com>
…etadata_small_update
Signed-off-by: VAmuzing <amuzik95@gmail.com>
Erigara
reviewed
Dec 26, 2023
Erigara
reviewed
Dec 26, 2023
0x009922
reviewed
Dec 26, 2023
Signed-off-by: VAmuzing <amuzik95@gmail.com>
5 tasks
…vor of ValueArg Signed-off-by: VAmuzing <amuzik95@gmail.com>
Erigara
previously approved these changes
Jan 15, 2024
0x009922
previously approved these changes
Jan 15, 2024
Signed-off-by: VAmuzing <amuzik95@gmail.com>
0x009922
approved these changes
Jan 15, 2024
Erigara
approved these changes
Jan 15, 2024
Asem-Abdelhady
pushed a commit
to Asem-Abdelhady/iroha
that referenced
this pull request
Jan 22, 2024
…li to edit domain metadata (hyperledger-iroha#4175) Signed-off-by: Vladimir Pesterev <8786922+pesterev@users.noreply.github.com> Signed-off-by: VAmuzing <amuzik95@gmail.com> Co-authored-by: Vladimir Pesterev <8786922+pesterev@users.noreply.github.com> Signed-off-by: Asem-Abdelhady <asemshawkey@gmail.com>
4 tasks
Asem-Abdelhady
pushed a commit
to Asem-Abdelhady/iroha
that referenced
this pull request
Feb 9, 2024
…li to edit domain metadata (hyperledger-iroha#4175) Signed-off-by: Vladimir Pesterev <8786922+pesterev@users.noreply.github.com> Signed-off-by: VAmuzing <amuzik95@gmail.com> Co-authored-by: Vladimir Pesterev <8786922+pesterev@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fork of #4054 with a small update to from_str method
Linked issue
Closes #3974
Benefits
There won't be any confusions about why the same method for different structs implemented differently
Checklist
CONTRIBUTING.md