[feature] #4083: Add pprof-rs support #4250
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Erigara
requested review from
s8sato,
mversic,
Arjentix,
SamHSmith,
QuentinI,
outoftardis,
ilchu,
pesterev,
0x009922 and
DCNick3
as code owners
github-actions
bot
added
the
iroha2-dev
Erigara
force-pushed
the
pprof_integration
branch
from
8ed7b8e
to
f261fac
Compare
mversic
reviewed
Feb 2, 2024
mversic
reviewed
Feb 2, 2024
mversic
approved these changes
Feb 2, 2024
mversic
force-pushed
the
pprof_integration
branch
from
f261fac
to
8db1e02
Compare
DCNick3
approved these changes
Feb 6, 2024
Signed-off-by: Shanin Roman <shanin1000@yandex.ru>
mversic
force-pushed
the
pprof_integration
branch
from
8db1e02
to
d120838
Compare
Asem-Abdelhady
pushed a commit
to Asem-Abdelhady/iroha
that referenced
this pull request
Feb 11, 2024
…roha#4250) Signed-off-by: Shanin Roman <shanin1000@yandex.ru>
Erigara
added a commit
to Erigara/iroha
that referenced
this pull request
Feb 12, 2024
…roha#4250) Signed-off-by: Shanin Roman <shanin1000@yandex.ru>
Erigara
added a commit
to Erigara/iroha
that referenced
this pull request
Feb 12, 2024
…roha#4250) Signed-off-by: Shanin Roman <shanin1000@yandex.ru>
mversic
pushed a commit
that referenced
this pull request
Feb 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add torii endpoint to serve pprof profiles.
Changed debug to "limited" due to more detailed function names.
Added
-Z build-stdfor profiling image in order to force frame pointers in the std as well.Linked issue
Closes #4083
Benefits
Able to profile iroha without any privileges like (root access of linux cap).
Downsides
No kernel level traces.
Additional fragile dependency into our codebase.