Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[refactor]: delete NewParameter isi and use only SetParameter #4310

Conversation

Asem-Abdelhady
Copy link
Contributor

@Asem-Abdelhady Asem-Abdelhady commented Feb 21, 2024

Description

NewParameter is only used during genesis generation. it does not make sense to have it as ISI. Now the admin will generate the parameters during configuration and he can give permessions for other users to allow them to put parameters.

Linked issue

Checklist

  • I've read CONTRIBUTING.md
  • I've used the standard signed-off commit format (or will squash just before merging)
  • All applicable CI checks pass (or I promised to make them pass later)
  • (optional) I've written unit tests for the code changes
  • I replied to all comments after code review, marking all implemented changes with thumbs up

@github-actions github-actions bot added the iroha2-dev The re-implementation of a BFT hyperledger in RUST label Feb 21, 2024
@coveralls
Copy link

coveralls commented Feb 21, 2024

Pull Request Test Coverage Report for Build 8000907676

Details

  • -1 of 1 (0.0%) changed or added relevant line in 1 file are covered.
  • 2954 unchanged lines in 53 files lost coverage.
  • Overall coverage decreased (-0.2%) to 56.574%

Changes Missing Coverage Covered Lines Changed/Added Lines %
tools/kagami/src/genesis.rs 0 1 0.0%
Files with Coverage Reduction New Missed Lines %
core/src/sumeragi/network_topology.rs 1 98.78%
tools/kagami/src/crypto.rs 1 12.12%
data_model/src/metadata.rs 2 78.87%
primitives/src/unique_vec.rs 2 91.24%
config/src/kura.rs 3 80.0%
config/src/logger.rs 5 72.73%
logger/src/lib.rs 5 94.12%
tools/kagami/src/main.rs 5 0.0%
crypto/src/signature/secp256k1.rs 7 96.09%
telemetry/src/dev.rs 7 0.0%
Totals Coverage Status
Change from base Build 7884695009: -0.2%
Covered Lines: 22413
Relevant Lines: 39617

💛 - Coveralls

configs/swarm/genesis.json Outdated Show resolved Hide resolved
@Asem-Abdelhady Asem-Abdelhady force-pushed the remove-newParameter-isi branch 2 times, most recently from a7e0ff0 to 7ebbbae Compare February 21, 2024 08:09
@mversic
Copy link
Contributor

mversic commented Feb 21, 2024

we need a test that shows how we can create a new parameter in executor and then update it's value

Signed-off-by: Asem-Abdelhady <asemshawkey@gmail.com>
@github-actions github-actions bot added api-changes Changes in the API for client libraries config-changes Changes in configuration and start up of the Iroha labels Feb 22, 2024
Copy link

@BAStos525

@0x009922 0x009922 self-assigned this Feb 26, 2024
@s8sato s8sato removed the config-changes Changes in configuration and start up of the Iroha label Feb 26, 2024
@mversic
Copy link
Contributor

mversic commented Feb 26, 2024

we need a test that shows how we can create a new parameter in executor and then update it's value

let's say that we want to define a parameter like max_accounts_per_domain in the executor and every time we register an account we also check for this parameter

Copy link

github-actions bot commented Jul 26, 2024

Hey there and thank you for opening this pull request! 👋🏼

We require pull request titles to follow the Conventional Commits specification, and it looks like your proposed title needs to be adjusted.

Details:

No release type found in pull request title "[refactor]: delete NewParameter isi and use only SetParameter". Add a prefix to indicate what kind of release this pull request corresponds to. For reference, see https://www.conventionalcommits.org/

Available types:
 - feat: A new feature
 - fix: A bug fix
 - docs: Documentation only changes
 - style: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc)
 - refactor: A code change that neither fixes a bug nor adds a feature
 - perf: A code change that improves performance
 - test: Adding missing tests or correcting existing tests
 - build: Changes that affect the build system or external dependencies (example scopes: gulp, broccoli, npm)
 - ci: Changes to our CI configuration files and scripts (example scopes: Travis, Circle, BrowserStack, SauceLabs)
 - chore: Other changes that don't modify src or test files
 - revert: Reverts a previous commit

@AlexStroke AlexStroke changed the title [refactor] #3901: delete NewParameter isi and use only SetParameter [refactor]: delete NewParameter isi and use only SetParameter Jul 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api-changes Changes in the API for client libraries iroha2-dev The re-implementation of a BFT hyperledger in RUST
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants