-
Notifications
You must be signed in to change notification settings - Fork 279
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[refactor]: delete NewParameter isi and use only SetParameter #4310
[refactor]: delete NewParameter isi and use only SetParameter #4310
Conversation
Pull Request Test Coverage Report for Build 8000907676Details
💛 - Coveralls |
fd6063e
to
29583ce
Compare
a7e0ff0
to
7ebbbae
Compare
we need a test that shows how we can create a new parameter in executor and then update it's value |
Signed-off-by: Asem-Abdelhady <asemshawkey@gmail.com>
7ebbbae
to
cab1f17
Compare
let's say that we want to define a parameter like |
Hey there and thank you for opening this pull request! 👋🏼 We require pull request titles to follow the Conventional Commits specification, and it looks like your proposed title needs to be adjusted. Details:
|
Description
NewParameter
is only used during genesis generation. it does not make sense to have it as ISI. Now the admin will generate the parameters during configuration and he can give permessions for other users to allow them to put parameters.Linked issue
Checklist
CONTRIBUTING.md