-
Notifications
You must be signed in to change notification settings - Fork 279
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[refactor] #4323: telemetry features, tokio console, logs, and configuration #4377
Merged
0x009922
merged 19 commits into
hyperledger-iroha:iroha2-dev
from
0x009922:config-tokio-console
Mar 26, 2024
Merged
[refactor] #4323: telemetry features, tokio console, logs, and configuration #4377
0x009922
merged 19 commits into
hyperledger-iroha:iroha2-dev
from
0x009922:config-tokio-console
Mar 26, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0x009922
added
Enhancement
New feature or request
iroha2-dev
The re-implementation of a BFT hyperledger in RUST
config-changes
Changes in configuration and start up of the Iroha
Refactor
Improvement to overall code quality
labels
Mar 21, 2024
0x009922
requested review from
s8sato,
mversic,
Arjentix,
SamHSmith,
outoftardis,
Erigara,
DCNick3,
VAmuzing and
Asem-Abdelhady
as code owners
March 21, 2024 02:00
mversic
reviewed
Mar 21, 2024
mversic
reviewed
Mar 21, 2024
…eature Signed-off-by: Dmitry Balashov <43530070+0x009922@users.noreply.github.com>
Signed-off-by: Dmitry Balashov <43530070+0x009922@users.noreply.github.com>
- remove `tokio_console_address` configuration - leverage default ENVs for tokio console config - `iroha_logger/tokio-console` feature fully controls whether it is enabled - refactoring chores Signed-off-by: Dmitry Balashov <43530070+0x009922@users.noreply.github.com>
Signed-off-by: Dmitry Balashov <43530070+0x009922@users.noreply.github.com>
Signed-off-by: Dmitry Balashov <43530070+0x009922@users.noreply.github.com>
0x009922
force-pushed
the
config-tokio-console
branch
from
March 22, 2024 01:00
c5b9cca
to
c30eb97
Compare
Signed-off-by: Dmitry Balashov <43530070+0x009922@users.noreply.github.com>
Signed-off-by: Dmitry Balashov <43530070+0x009922@users.noreply.github.com>
Signed-off-by: Dmitry Balashov <43530070+0x009922@users.noreply.github.com>
Signed-off-by: Dmitry Balashov <43530070+0x009922@users.noreply.github.com>
Signed-off-by: Dmitry Balashov <43530070+0x009922@users.noreply.github.com>
Signed-off-by: Dmitry Balashov <43530070+0x009922@users.noreply.github.com>
Signed-off-by: Dmitry Balashov <43530070+0x009922@users.noreply.github.com>
Signed-off-by: Dmitry Balashov <43530070+0x009922@users.noreply.github.com>
Signed-off-by: Dmitry Balashov <43530070+0x009922@users.noreply.github.com>
Signed-off-by: Dmitry Balashov <43530070+0x009922@users.noreply.github.com>
0x009922
changed the title
[refactor] #4323: re-arrange telemetry & tokio console config
[refactor] #4323: telemetry features, tokio console, logs, and configuration
Mar 22, 2024
Signed-off-by: Dmitry Balashov <43530070+0x009922@users.noreply.github.com>
Signed-off-by: Dmitry Balashov <43530070+0x009922@users.noreply.github.com>
Signed-off-by: Dmitry Balashov <43530070+0x009922@users.noreply.github.com>
Erigara
reviewed
Mar 25, 2024
Is telemetry used at all? I'm aware that QA and DevOps team using prometheus metrics. |
Signed-off-by: Dmitry Balashov <43530070+0x009922@users.noreply.github.com>
Pull Request Test Coverage Report for Build 8428396018Details
💛 - Coveralls |
mversic
approved these changes
Mar 26, 2024
Erigara
approved these changes
Mar 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
api-changes
Changes in the API for client libraries
config-changes
Changes in configuration and start up of the Iroha
Enhancement
New feature or request
iroha2-dev
The re-implementation of a BFT hyperledger in RUST
Refactor
Improvement to overall code quality
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is an improved iteration of #4369
logger.tokio_console_address
configuration parameter entirely: this could be configured in a more refined way using default ENVs (seeconsole_subscriber
docs)[telemetry.dev]
config section to[dev_telemetry]
telemetry
anddev-telemetry
features ofiroha
tokio-console
feature ofiroha_logger
: now console seamlessly starts whenever this feature is enabled\n
, and recursively create parent directoriesLinked issue
Closes #4323
Benefits
Checklist
Cargo.toml
stelemetry
/dev-telemetry
features enabled depending ontelemetry
configuration (warnings, logs, file output)TRACE
log level)