remove transactions copy

[iceseer]

Signed-off-by: iceseer iceseer@gmail.com

Description of the Change

Performance fix.

Benefits

Possible Drawbacks

Usage Examples or Tests [optional]

Alternate Designs [optional]

[MBoldyrev]

Generally, shared objects should be const so that they would not change when not expected to. I would like to keep shared pointer to const block in the interfaces. The change you make does not demand the interface to use non-const shared block.

IMHO, what is wrong here is the block creator (fetch method) creating a const object. To be consistent with my first point, this producer should rather create a non-const unique pointer, and if the component that gets this block needs to share it, it is responsible for making it a shared const. If it does not need to share, then it has a non-const block that it can move transactions from without any risk of messing someone other's view.

[MBoldyrev]

Suggested change

	std::shared_ptr<shared_model::interface::Block>>
	fetch(shared_model::interface::types::HeightType height) = 0;
	std::unique_ptr<shared_model::interface::Block>>
	fetch(shared_model::interface::types::HeightType height) const = 0;

[MBoldyrev]

Suggested change

	virtual void forEach(FunctionType function) = 0;
	virtual void forEach(FunctionType function) const = 0;