refactor: Reject BlockMessages
eagerly
#4606
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently we may ignore
BlockMessage::BlockCreated
if it's view change index is less then view change index of control message received in same invocation ofreceive_network_packet
function. E.g. currently we have such behaviour:This PR extends this behaviour to support more cases, e.g.:
Linked issue
Closes #4223
Benefits
Checklist
CONTRIBUTING.md