Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Allow multiple peers submit genesis block #4775

Merged
merged 3 commits into from
Jun 27, 2024
Merged

feat: Allow multiple peers submit genesis block #4775

merged 3 commits into from
Jun 27, 2024

Conversation

dima74
Copy link
Contributor

@dima74 dima74 commented Jun 26, 2024 •
edited
Loading

Description

Continuation of #4739:

  • Topology stored in genesis block will be used as initial topology, as a result multiple peers can submit genesis
  • Removed --submit-genesis flag
  • Changed scripts/test_env.py, it will submit genesis for all peers

Linked issue

Closes #4696

Benefits

Checklist

  • I've read CONTRIBUTING.md
  • I've used the standard signed-off commit format (or will squash just before merging)
  • All applicable CI checks pass (or I promised to make them pass later)
  • (optional) I've written unit tests for the code changes
  • I replied to all comments after code review, marking all implemented changes with thumbs up

@dima74 dima74 self-assigned this Jun 26, 2024
@mversic mversic self-assigned this Jun 26, 2024
mversic
mversic reviewed Jun 26, 2024
View reviewed changes
scripts/test_env.py Outdated Show resolved Hide resolved
mversic
mversic requested changes Jun 27, 2024
View reviewed changes
Copy link
Contributor

@mversic mversic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you should remove the --submit-genesis flag? A peer should check if the genesis file has been set and based on that submit a genesis

@dima74
refactor: Introduce NetworkBuilder to test multiple genesis
2840029 
Signed-off-by: Dmitry Murzin <diralik@yandex.ru>
@dima74
feat: Allow multiple peers submit genesis block
4f00181 
Signed-off-by: Dmitry Murzin <diralik@yandex.ru>
@dima74
Review fixes
89b0c30 
Signed-off-by: Dmitry Murzin <diralik@yandex.ru>
@dima74 dima74 force-pushed the diralik/multiple-peers-submit-genesis branch from 096df69 to 89b0c30 Compare June 27, 2024 11:06
@dima74 dima74 requested a review from mversic June 27, 2024 11:09
@mversic mversic merged commit 877444b into hyperledger-iroha:main Jun 27, 2024
10 of 12 checks passed
@dima74
Copy link
Contributor Author

dima74 commented Jun 27, 2024

  • Removed --submit-genesis flag

@BAStos525 this is the only change needed from the deployment point of view

@dima74 dima74 deleted the diralik/multiple-peers-submit-genesis branch June 27, 2024 11:46
hollermay pushed a commit to hollermay/iroha that referenced this pull request Jun 28, 2024
@dima74 @hollermay
feat: Allow multiple peers submit genesis block (hyperledger-iroha#4775)
7fc7f71 
Signed-off-by: Dmitry Murzin <diralik@yandex.ru>
@dima74 dima74 mentioned this pull request Jul 5, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mversic mversic mversic approved these changes

@nxsaken nxsaken nxsaken approved these changes

@s8sato s8sato Awaiting requested review from s8sato s8sato is a code owner

@SamHSmith SamHSmith Awaiting requested review from SamHSmith SamHSmith is a code owner

@outoftardis outoftardis Awaiting requested review from outoftardis outoftardis is a code owner

@Erigara Erigara Awaiting requested review from Erigara

@0x009922 0x009922 Awaiting requested review from 0x009922 0x009922 is a code owner

@DCNick3 DCNick3 Awaiting requested review from DCNick3 DCNick3 is a code owner

Assignees

@dima74 dima74

@mversic mversic

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow multiple peers submit genesis
3 participants
@dima74 @nxsaken @mversic