Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor!: split executor data model #4791

Merged
merged 1 commit into from
Jul 1, 2024
Merged

refactor!: split executor data model #4791

merged 1 commit into from
Jul 1, 2024

Conversation

mversic
Copy link
Contributor

@mversic mversic commented Jun 30, 2024 •
edited
Loading

Description

  • remove derive crates from workspace dependencies
  • split executor into data_model and core crates
  • rewrite tests/examples so that they use statically typed permissions
  • removed MigrationResult -> migration should always succeed, the error is unrecoverable

Linked issue

#4552

Benefits

  • we will never see json! again

Checklist

  • I've read CONTRIBUTING.md
  • I've used the standard signed-off commit format (or will squash just before merging)
  • All applicable CI checks pass (or I promised to make them pass later)
  • (optional) I've written unit tests for the code changes
  • I replied to all comments after code review, marking all implemented changes with thumbs up

nxsaken
nxsaken reviewed Jul 1, 2024
View reviewed changes
client/tests/integration/permissions.rs Outdated Show resolved Hide resolved
client/tests/integration/permissions.rs Outdated Show resolved Hide resolved
@mversic mversic force-pushed the permissions_data_model branch 3 times, most recently from 0036e62 to a27e361 Compare July 1, 2024 06:56
@nxsaken
Copy link
Contributor

nxsaken commented Jul 1, 2024

Schema and formatting checks failed

@github-actions github-actions bot added the api-changes Changes in the API for client libraries label Jul 1, 2024
@mversic mversic force-pushed the permissions_data_model branch 4 times, most recently from 8e4af7f to c2e0461 Compare July 1, 2024 08:45
@mversic mversic requested a review from nxsaken July 1, 2024 08:45
@mversic mversic force-pushed the permissions_data_model branch 5 times, most recently from d423b54 to cd793e3 Compare July 1, 2024 10:26
nxsaken
nxsaken previously approved these changes Jul 1, 2024
View reviewed changes
@mversic mversic force-pushed the permissions_data_model branch 3 times, most recently from bade3f1 to 4c870e1 Compare July 1, 2024 13:57
@mversic mversic requested review from nxsaken and Erigara July 1, 2024 13:59
nxsaken
nxsaken previously approved these changes Jul 1, 2024
View reviewed changes
@mversic mversic enabled auto-merge (squash) July 1, 2024 15:43
@mversic mversic requested a review from nxsaken July 1, 2024 15:55
@mversic
refactor!: split executor data model
7499e0d 
Signed-off-by: Marin Veršić <marin.versic101@gmail.com>
@mversic mversic merged commit 99745dc into hyperledger-iroha:main Jul 1, 2024
12 of 13 checks passed
@mversic mversic deleted the permissions_data_model branch July 1, 2024 18:14
@mversic mversic mentioned this pull request Jul 8, 2024
Closed
@mversic mversic mentioned this pull request Oct 8, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Erigara Erigara Erigara approved these changes

@nxsaken nxsaken nxsaken approved these changes

@s8sato s8sato Awaiting requested review from s8sato s8sato is a code owner

@SamHSmith SamHSmith Awaiting requested review from SamHSmith SamHSmith is a code owner

@outoftardis outoftardis Awaiting requested review from outoftardis outoftardis is a code owner

@0x009922 0x009922 Awaiting requested review from 0x009922 0x009922 is a code owner

@DCNick3 DCNick3 Awaiting requested review from DCNick3 DCNick3 is a code owner

@dima74 dima74 Awaiting requested review from dima74 dima74 is a code owner

Assignees

@nxsaken nxsaken

@Erigara Erigara

@mversic mversic

Labels
api-changes Changes in the API for client libraries
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mversic @nxsaken @Erigara