Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(schema): rename type_ to type in schema #4855

Merged
merged 1 commit into from
Jul 17, 2024
Merged

fix(schema): rename type_ to type in schema #4855

merged 1 commit into from
Jul 17, 2024

Conversation

mversic
Copy link
Contributor

@mversic mversic commented Jul 17, 2024

Description

  • add support for handling serde(rename) attributes with IntoSchema
  • attach serde(rename = "type") to type_ fields in data model

Linked issue

Closes #4770

Benefits

Checklist

  • I've read CONTRIBUTING.md
  • I've used the standard signed-off commit format (or will squash just before merging)
  • All applicable CI checks pass (or I promised to make them pass later)
  • (optional) I've written unit tests for the code changes
  • I replied to all comments after code review, marking all implemented changes with thumbs up

@github-actions github-actions bot added the api-changes Changes in the API for client libraries label Jul 17, 2024
@mversic mversic force-pushed the rename_type_ branch 3 times, most recently from 22caa96 to 56a3a78 Compare July 17, 2024 12:39
@mversic
fix(schema): rename type_ to type in schema
69286b1 
Signed-off-by: Marin Veršić <marin.versic101@gmail.com>
@mversic mversic enabled auto-merge (squash) July 17, 2024 13:36
@mversic mversic merged commit 8557265 into hyperledger-iroha:main Jul 17, 2024
12 of 13 checks passed
@dima74 dima74 mentioned this pull request Jul 17, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Erigara Erigara Erigara approved these changes

@nxsaken nxsaken nxsaken approved these changes

@s8sato s8sato Awaiting requested review from s8sato s8sato is a code owner

@SamHSmith SamHSmith Awaiting requested review from SamHSmith SamHSmith is a code owner

@outoftardis outoftardis Awaiting requested review from outoftardis outoftardis is a code owner

@0x009922 0x009922 Awaiting requested review from 0x009922 0x009922 is a code owner

@DCNick3 DCNick3 Awaiting requested review from DCNick3 DCNick3 is a code owner

@dima74 dima74 Awaiting requested review from dima74 dima74 is a code owner

Assignees
No one assigned
Labels
api-changes Changes in the API for client libraries
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Rename type_ to type in schema.json
3 participants
@mversic @nxsaken @Erigara