fix(kura): correctly handle replace_top_block #4870
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Erigara
requested review from
s8sato,
mversic,
SamHSmith,
outoftardis,
0x009922,
DCNick3 and
dima74
as code owners
Erigara
force-pushed
the
kura_miss_replace_top
branch
from
ecffc7c
to
6f7d968
Compare
mversic
reviewed
Jul 26, 2024
nxsaken
force-pushed
the
kura_miss_replace_top
branch
from
6f7d968
to
38d7eed
Compare
DCNick3
reviewed
Aug 5, 2024
DCNick3
previously approved these changes
Aug 7, 2024
Erigara
force-pushed
the
kura_miss_replace_top
branch
from
38d7eed
to
b71ec1a
Compare
DCNick3
reviewed
Aug 8, 2024
Erigara
force-pushed
the
kura_miss_replace_top
branch
from
b71ec1a
to
351d603
Compare
DCNick3
previously approved these changes
Aug 8, 2024
mversic
force-pushed
the
kura_miss_replace_top
branch
from
351d603
to
13937b1
Compare
Erigara
force-pushed
the
kura_miss_replace_top
branch
from
13937b1
to
e603436
Compare
mversic
approved these changes
Aug 26, 2024
Signed-off-by: Shanin Roman <shanin1000@yandex.ru>
Signed-off-by: Shanin Roman <shanin1000@yandex.ru>
Signed-off-by: Shanin Roman <shanin1000@yandex.ru>
Signed-off-by: Shanin Roman <shanin1000@yandex.ru>
mversic
force-pushed
the
kura_miss_replace_top
branch
from
e603436
to
72eae0c
Compare
mversic
pushed a commit
that referenced
this pull request
Aug 30, 2024
* test(kura): add test kura not miss replace top block call * fix(kura): properly initialize kura * fix(kura): correctly handle replace_top_block * fix(kura): fix warnings inside kura --------- Signed-off-by: Shanin Roman <shanin1000@yandex.ru>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I've noticed multiple issues with kura which this PR is aimed to fix.
replace_top_blockandstore_blockcause kura to omit overwriting soft-fork blockstore_blockbefore or just afterstartcause kura to incorrectly assume amount of already written blocksBenefits
Fewer bugs.
How to test
To check this issues
create_blockstest was added.