Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: remove committed_topology from block #4880

Merged
merged 3 commits into from
Jul 24, 2024
Merged

refactor: remove committed_topology from block #4880

merged 3 commits into from
Jul 24, 2024

Conversation

Erigara
Copy link
Contributor

@Erigara Erigara commented Jul 23, 2024

Description

  • committed topology is removed from block
  • committed topology for latest and previous blocks are stored in the state
    • it's required for blocks sync
    • and for initializing state from the snapshot + block store
  • initial topology in the genesis block is passed as transaction with Register<Peer> instructions
  • trusted peers are removed from World constructor

Linked issue

Closes #4879

Benefits

Less space used in the block store, easier to derive block hash.

How to test

Run, try to submit new blocks, try restart peers check that iroha operates as usual.

@Erigara Erigara added the Refactor Improvement to overall code quality label Jul 23, 2024
@Erigara Erigara self-assigned this Jul 23, 2024
@github-actions github-actions bot added the api-changes Changes in the API for client libraries label Jul 23, 2024
mversic
mversic requested changes Jul 23, 2024
View reviewed changes
core/src/state.rs Outdated Show resolved Hide resolved
core/src/sumeragi/main_loop.rs Show resolved Hide resolved
@Erigara Erigara force-pushed the no_topology_in_block branch 2 times, most recently from 7ed6b07 to 5558ab0 Compare July 23, 2024 14:20
mversic
mversic previously approved these changes Jul 23, 2024
View reviewed changes
Copy link
Contributor

@mversic mversic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes me very happy

@mversic mversic self-assigned this Jul 23, 2024
@mversic mversic enabled auto-merge (squash) July 24, 2024 14:35
nxsaken
nxsaken previously approved these changes Jul 24, 2024
View reviewed changes
core/src/block.rs Outdated Show resolved Hide resolved
@nxsaken
Copy link
Contributor

nxsaken commented Jul 24, 2024

Compilation fails, and something's wrong with the commit sign-off

@Erigara
refactor: remove committed_topology from block
2b475f1 
Signed-off-by: Shanin Roman <shanin1000@yandex.ru>
@Erigara
refactor(block): simplify singatures check
04cb719 
Signed-off-by: Shanin Roman <shanin1000@yandex.ru>
@Erigara Erigara dismissed stale reviews from nxsaken and mversic via 04cb719 July 24, 2024 15:17
mversic
mversic previously approved these changes Jul 24, 2024
View reviewed changes
@Erigara
fix(snapshot): pass topology into apply_without_execution
82d861e 
Signed-off-by: Shanin Roman <shanin1000@yandex.ru>
@mversic mversic merged commit 336fadd into hyperledger-iroha:main Jul 24, 2024
12 of 13 checks passed
@s8sato s8sato mentioned this pull request Jul 25, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mversic mversic mversic approved these changes

@nxsaken nxsaken nxsaken approved these changes

@s8sato s8sato Awaiting requested review from s8sato s8sato is a code owner

@SamHSmith SamHSmith Awaiting requested review from SamHSmith SamHSmith is a code owner

@outoftardis outoftardis Awaiting requested review from outoftardis outoftardis is a code owner

@0x009922 0x009922 Awaiting requested review from 0x009922 0x009922 is a code owner

@DCNick3 DCNick3 Awaiting requested review from DCNick3 DCNick3 is a code owner

@dima74 dima74 Awaiting requested review from dima74 dima74 is a code owner

Assignees

@Erigara Erigara

@mversic mversic

Labels
api-changes Changes in the API for client libraries Refactor Improvement to overall code quality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

refactor: remove committed_topology field from blocks
3 participants
@Erigara @nxsaken @mversic