Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(torii): use GET for blocks stream #4990

Merged
merged 1 commit into from
Aug 21, 2024
Merged

fix(torii): use GET for blocks stream #4990

merged 1 commit into from
Aug 21, 2024

Conversation

0x009922
Copy link
Contributor

Context

Blocks stream endpoint doesn't work with standard WebSocket clients because it uses POST. The standard says it should be GET: https://stackoverflow.com/questions/50386211/should-websocket-server-only-handle-get-requests

Solution

Use GET for blocks stream route.

Events stream already uses GET (discrepancy btw).

Checklist

  • I've read CONTRIBUTING.md.
  • (optional) I've written unit tests for the code changes.
  • All review comments have been resolved.

@0x009922
fix(torii): use GET for blocks stream
cf5159f 
Signed-off-by: 0x009922 <43530070+0x009922@users.noreply.github.com>
@0x009922 0x009922 added Bug Something isn't working Chore This is a small task that can be done at any point in time and is easier than others labels Aug 21, 2024
@0x009922 0x009922 self-assigned this Aug 21, 2024
@github-actions github-actions bot added the api-changes Changes in the API for client libraries label Aug 21, 2024
@nxsaken nxsaken merged commit 2810e1b into hyperledger-iroha:main Aug 21, 2024
10 of 12 checks passed
mversic pushed a commit that referenced this pull request Aug 30, 2024
@0x009922 @mversic
fix(torii): use GET for blocks stream (#4990)
e9d66da 
Signed-off-by: 0x009922 <43530070+0x009922@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mversic mversic mversic approved these changes

@Mingela Mingela Mingela approved these changes

@s8sato s8sato Awaiting requested review from s8sato s8sato is a code owner

@SamHSmith SamHSmith Awaiting requested review from SamHSmith SamHSmith is a code owner

@outoftardis outoftardis Awaiting requested review from outoftardis outoftardis is a code owner

@Erigara Erigara Awaiting requested review from Erigara

@DCNick3 DCNick3 Awaiting requested review from DCNick3 DCNick3 is a code owner

@dima74 dima74 Awaiting requested review from dima74 dima74 is a code owner

Assignees

@0x009922 0x009922

Labels
api-changes Changes in the API for client libraries Bug Something isn't working Chore This is a small task that can be done at any point in time and is easier than others
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@0x009922 @Mingela @mversic @nxsaken