Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: use HashOf<BlockHeader> as the type of the block hash #4998

Merged
merged 1 commit into from
Aug 23, 2024
Merged

refactor: use HashOf<BlockHeader> as the type of the block hash #4998

merged 1 commit into from
Aug 23, 2024

Conversation

mversic
Copy link
Contributor

@mversic mversic commented Aug 21, 2024 •
edited
Loading

Context

  • block.hash() returns HashOf<SignedBlock>

Solution

  • change the function so that it returns HashOf<BlockHeader>

Review notes (optional)

  • For complex PRs, try to provide some information on how to approach the review more effectively.
  • For example, is there a natural order in which the affected files should be reviewed?

Checklist

  • I've read CONTRIBUTING.md.
  • (optional) I've written unit tests for the code changes.
  • All review comments have been resolved.

@github-actions github-actions bot added the api-changes Changes in the API for client libraries label Aug 21, 2024
@mversic mversic force-pushed the block_hash_fix branch 5 times, most recently from f32f57a to 9addbe2 Compare August 22, 2024 12:32
@mversic
refactor: use HashOf<BlockHeader> as the type of the block hash
b17c51e 
Signed-off-by: Marin Veršić <marin.versic101@gmail.com>
0x009922
0x009922 approved these changes Aug 23, 2024
View reviewed changes
Copy link
Contributor

@0x009922 0x009922 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just faced this minor inconsistency recently in Explorer.

@nxsaken nxsaken merged commit a27bc2e into hyperledger-iroha:main Aug 23, 2024
11 of 13 checks passed
mversic added a commit that referenced this pull request Aug 30, 2024
@mversic
refactor: use HashOf<BlockHeader> as the type of the block hash (#4998
c2ce434 
)

Signed-off-by: Marin Veršić <marin.versic101@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0x009922 0x009922 0x009922 approved these changes

@s8sato s8sato Awaiting requested review from s8sato s8sato is a code owner

@SamHSmith SamHSmith Awaiting requested review from SamHSmith SamHSmith is a code owner

@outoftardis outoftardis Awaiting requested review from outoftardis outoftardis is a code owner

@Erigara Erigara Awaiting requested review from Erigara

@DCNick3 DCNick3 Awaiting requested review from DCNick3 DCNick3 is a code owner

@dima74 dima74 Awaiting requested review from dima74 dima74 is a code owner

Assignees

@nxsaken nxsaken

@0x009922 0x009922

@mversic mversic

Labels
api-changes Changes in the API for client libraries
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mversic @0x009922 @nxsaken