perf: Reduce memory usage of CommittedTransaction
#5089
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dima74
requested review from
s8sato,
mversic,
SamHSmith,
outoftardis,
Erigara,
0x009922 and
DCNick3
as code owners
|
relevant #5001 |
dima74
force-pushed
the
diralik/transaction-error-box
branch
from
ffaf5bf
to
f7d4fc8
Compare
mversic
reviewed
Sep 20, 2024
DCNick3
approved these changes
Sep 20, 2024
Signed-off-by: Dmitry Murzin <diralik@yandex.ru>
Co-authored-by: Marin Veršić <marin.versic101@gmail.com> Signed-off-by: Dmitry Murzin <diralik@yandex.ru>
dima74
force-pushed
the
diralik/transaction-error-box
branch
from
9df604a
to
ee1cc26
Compare
mversic
approved these changes
Sep 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Related: #5083
Solution
CommittedTransaction::errortakes 200 bytes and isNonein case of a successful transaction. UsingOption<Box<...>reduces memory usage of iroha approximately by 10% (considering that all transactions are successful and with testing configuration as in #5083)Checklist
CONTRIBUTING.md.