-
Notifications
You must be signed in to change notification settings - Fork 215
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump inkwell and other crates #1622
Conversation
bb14e80
to
be772cc
Compare
Signed-off-by: Sean Young <sean@mess.org>
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #1622 +/- ##
==========================================
+ Coverage 88.43% 88.58% +0.15%
==========================================
Files 150 150
Lines 68200 69335 +1135
==========================================
+ Hits 60311 61420 +1109
- Misses 7889 7915 +26 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks
@@ -28,12 +28,12 @@ tiny-keccak = { version = "2.0", features = ["keccak"] } | |||
serde_json = "1.0" | |||
serde = "1.0" | |||
serde_derive = { version = "1.0" } | |||
inkwell = { version = "0.2.0", features = ["target-webassembly", "no-libffi-linking", "llvm16-0"], optional = true } | |||
inkwell = { version = "0.4.0", features = ["target-webassembly", "no-libffi-linking", "llvm16-0"], optional = true } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since inkwell 0.3.0 introduced support for LLVM 17 we could switch to LLVM 17 too in the near future WDYT?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Totally, that's one reason I wanted to update inkwell
Update crates dependencies and fix the CI problems.