Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Wrong metric data used in contributors chart. #820

Closed
frank-zsy opened this issue May 22, 2024 · 4 comments · Fixed by #821
Closed

[Bug] Wrong metric data used in contributors chart. #820

frank-zsy opened this issue May 22, 2024 · 4 comments · Fixed by #821
Labels
kind/bug Category issues or prs related to bug.
Milestone

Comments

@frank-zsy
Copy link
Contributor

Version

1.9.6

Current Behavior

As implemented in #794 , the data used right now is new_contributors, but we should use contributors metrics because the meaning of the chart just like participants, which is the active contributors in the repo but not new contributors.

Expected Behavior

Use contributors metrics instead of new_contributors

Environment

- OS: MacOS
- Browser: Chrome

Any additional comments?

No response

@frank-zsy frank-zsy added the kind/bug Category issues or prs related to bug. label May 22, 2024
@frank-zsy
Copy link
Contributor Author

frank-zsy commented May 22, 2024

Can use https://github.com/redis/redis to check the data, latest contributors count in the repo should 4 but not 0.

@tyn1998
Copy link
Member

tyn1998 commented May 22, 2024

Hello @Tenth-crew, could you handle this?

@Tenth-crew
Copy link
Collaborator

OK, I've made the changes. Previously, new_contributors was used because the Metric in opendigger's Readme did not list contributors but only new_contributors and Inactive contributors. I mistakenly thought that there were only these two metrics for contributors. If there is a complete metric somewhere, can you give me a link to check it out? In addition, maybe the metrics supported in the opendigger Readme can be updated later.
81ff2ad71ec2f30789e11871d9a3b5dd
image

@frank-zsy
Copy link
Contributor Author

@Tenth-crew Yes, this should be a missing metric in README since the metric is implemented recently. Will fix this soon.

@tyn1998 tyn1998 added this to the 1.9.7 milestone Jun 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Category issues or prs related to bug.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants