Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Module scripts don't load in ViaHTML (affects patterns.hypothes.is) #527

Open
robertknight opened this issue Jul 21, 2023 · 0 comments
Open

Module scripts don't load in ViaHTML (affects patterns.hypothes.is) #527

robertknight opened this issue Jul 21, 2023 · 0 comments

Comments

@robertknight
Copy link
Member

JavaScript that is loaded as a native ES module via <script type="module"> fails load in ViaHTML, due to webrecorder/pywb#771.

This issue causes our pattern library to failed to load when proxied: https://via.hypothes.is/https://patterns.hypothes.is/.

The console error includes a messages about variables named "arguments":

Pattern library error

This error comes from the JS bundle's preamble after it has been preprocessed by pywb:

Pattern library JS load error
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@robertknight