Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

zext_workspace_handle_v1.activate() for empty workspaces #2632

Closed
MonstrousOgre opened this issue Jul 3, 2023 · 10 comments
Closed

zext_workspace_handle_v1.activate() for empty workspaces #2632

MonstrousOgre opened this issue Jul 3, 2023 · 10 comments
Labels
enhancement New feature or request

Comments

@MonstrousOgre
Copy link

I'm one of the contributors of waybar, and the one who implemented persistent workspaces.

With #2084 being implemented, you no longer need the patch to switch to workspaces with windows in them. This isn't true for empty persistent workspaces though, since they still require hyprctl to switch to.

Pardon my lack of wlroots knowledge, but is it possible to implement zext_workspace_handle_v1.activate() for empty workspaces? It is my undersanding that the workspace wouldn't exist and would need to be created when activate is called.

@MonstrousOgre MonstrousOgre added the enhancement New feature or request label Jul 3, 2023
@vaxerski
Copy link
Member

vaxerski commented Jul 3, 2023

you can read the protocol spec yourself to make sure but iirc clients cannot create workspace handles

@q234rty
Copy link
Contributor

q234rty commented Jul 6, 2023

I believe the protocol spec includes a "create" request to request creating a workspace though I'm not sure whether hyprland handles that at all...

@vaxerski
Copy link
Member

vaxerski commented Jul 6, 2023

image
oh, yeah.

No, we don't, but we can. Theoretically it's just about turning that into hyprctl dispatch workspace <str> xD

@Neodiablow
Copy link

I would also be very interested (for reasons unrelated to waybar) in having an "empty not focused workspace".
It's annoying to have them be destroyed whenever you switch to another one.

@vaxerski
Copy link
Member

vaxerski commented Jul 8, 2023

why so? What's the point of keeping them open if you can use any and all dispatchers to get to them regardless of their open state?

Besides, you can write a simple plugin to keep them open, lol

@MonstrousOgre
Copy link
Author

@vaxerski is the create workspace request something you'd be willing to implement? If so, I can make the necessary changes in waybar

@MightyPlaza
Copy link
Contributor

there is a PR for hyprland/workspaces to allow clicking in workspaces (Alexays/Waybar#2316)
hyprland/workspaces also uses hyprland's sockets so should be fully working, just needs to get merged and persistent workspaces to be implemented.

@vaxerski
Copy link
Member

I can

@MonstrousOgre
Copy link
Author

@MightyPlaza last I remember, there wasn't a hyprland/workspaces module for waybar. Just a wlr/workspaces. It's nice to know there's now one implemented specifically for Hyprland. I could help with the persistent workspaces part

@MonstrousOgre
Copy link
Author

I guess with Alexays/Waybar#2341, this isn't necessary

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

5 participants