dwindle:no_gaps_when_only = 1 still has corners after the other window closes

[eriedaberrie]

Hyprland Version

System/Version info

Hyprland, built from branch  at commit 185a3b48814cc4a1afbf32a69792a6161c4038cd  ().
Date: 2024-04-11
Tag: , commits: @COMMITS@

flags: (if any)


System Information:
System name: Linux
Node name: msft-laptop
Release: 6.8.4
Version: #1-NixOS SMP PREEMPT_DYNAMIC Thu Apr  4 18:25:06 UTC 2024


GPU information: 
c1:00.0 VGA compatible controller [0300]: Advanced Micro Devices, Inc. [AMD/ATI] Phoenix1 [1002:15bf] (rev c2) (prog-if 00 [VGA controller])


os-release: ANSI_COLOR="1;34"
BUG_REPORT_URL="https://github.com/NixOS/nixpkgs/issues"
BUILD_ID="24.05.20240408.4cba8b5"
DOCUMENTATION_URL="https://nixos.org/learn.html"
HOME_URL="https://nixos.org/"
ID=nixos
IMAGE_ID=""
IMAGE_VERSION=""
LOGO="nix-snowflake"
NAME=NixOS
PRETTY_NAME="NixOS 24.05 (Uakari)"
SUPPORT_URL="https://nixos.org/community.html"
VERSION="24.05 (Uakari)"
VERSION_CODENAME=uakari
VERSION_ID="24.05"


plugins:

Bug or Regression?

Regression

Description

With dwindle:no_gaps_when_only set to 1, I expect the rounded corners to be hidden when only one window is in the workspace. However, if I close the second-to-last window, the remaining one loses its gaps and borders but keeps its rounded corners. I've bisected it to c35fa9b.

How to reproduce

Set dwindle:no_gaps_when_only to 1, open two windows in a workspace, and close one of them.

Crash reports, logs, images, videos

No response

[vaxerski]

no gaps when only should be marked as deprecated

[sungyoonc]

To replace it with the workspace selector, I think these should be added

• Make window rules to be able to tell if fullscreen mode is 0 ,1, or 2
• Mixed counting flag in windowcount workspace selector(non grouped windows + groups)
  (I think that's how no gaps when only calculates window count, I might be wrong)

I'll try to add these when I have time.

Also I don't know what this does, so might need more to accommodate this bit of code.

Hyprland/src/layout/DwindleLayout.cpp

Lines 170 to 175 in 79a139c

	const auto RESERVED = PWINDOW->getFullWindowReservedArea();
	PWINDOW->m_vRealPosition = PWINDOW->m_vPosition + RESERVED.topLeft;
	PWINDOW->m_vRealSize = PWINDOW->m_vSize - (RESERVED.topLeft + RESERVED.bottomRight);
	g_pXWaylandManager->setWindowSize(PWINDOW, PWINDOW->m_vRealSize.goal());

[vaxerski]

can someone bisect this

[eriedaberrie]

The original issue?

I've bisected it to c35fa9b.

[sungyoonc]

@eriedaberrie Can you test #5647?

[eriedaberrie]

Yup, I think that's fixed it.