From 82eef4cfa96ac5aaedfa9f298e45d6313120b4bc Mon Sep 17 00:00:00 2001
From: hyrious <hyrious@outlook.com>
Date: Thu, 6 Jul 2023 12:18:42 +0800
Subject: [PATCH] refactor(service-providers): remember tool states like stroke
 width (#1962)

* chore(version): update changelog

* refactor(service-providers): remember tool states like stroke width
---
 service-providers/fastboard/src/index.ts | 68 ++++++++++++++++++++----
 1 file changed, 58 insertions(+), 10 deletions(-)

diff --git a/service-providers/fastboard/src/index.ts b/service-providers/fastboard/src/index.ts
index 1d617b85bd5..b4c8eaeb9cb 100644
--- a/service-providers/fastboard/src/index.ts
+++ b/service-providers/fastboard/src/index.ts
@@ -1,6 +1,6 @@
 import { createFastboard, createUI, FastboardApp, addManagerListener } from "@netless/fastboard";
 import { DeviceType, RoomPhase, DefaultHotKeys } from "white-web-sdk";
-import type { Camera } from "white-web-sdk";
+import type { Camera, MemberState } from "white-web-sdk";
 import type { FlatI18n } from "@netless/flat-i18n";
 import {
     IServiceWhiteboard,
@@ -203,10 +203,7 @@ export class Fastboard extends IServiceWhiteboard {
                 userPayload: {
                     uid,
                     nickName,
-                    // @deprecated
-                    userId: uid,
-                    // @deprecated
-                    cursorName: nickName,
+                    // avatar: "url/to/avatar.png",
                 },
                 isWritable: this.isWritable,
                 uid,
@@ -225,7 +222,7 @@ export class Fastboard extends IServiceWhiteboard {
                     changeToStraight: "l",
                     changeToArrow: "a",
                     changeToHand: "h",
-                    // disable builtin copy-paste hotkeys
+                    // disable builtin copy-paste hotkeys, they are used to paste images from user clipboard
                     copy: undefined,
                     paste: undefined,
                 },
@@ -298,21 +295,39 @@ export class Fastboard extends IServiceWhiteboard {
         );
 
         // enable "text select text" on writable, once
-        // set "text size = 36", once
         const disposeInitToolsId = "init-tools";
         this.sideEffect.push(
             fastboardAPP.writable.subscribe(writable => {
                 if (writable) {
                     fastboardAPP.toggleTextCanSelectText(true);
-                    if (fastboardAPP.memberState.value.textSize === 16) {
-                        fastboardAPP.setTextSize(36);
-                    }
                     this.sideEffect.flush(disposeInitToolsId);
                 }
             }),
             disposeInitToolsId,
         );
 
+        // restore and listen to appliance settings (i.e. memberState) on writable
+        const disposeMemberStateId = "member-state";
+        this.sideEffect.push(
+            fastboardAPP.writable.subscribe(writable => {
+                if (writable) {
+                    initMemberState(fastboardAPP);
+                    // 'subscribe' executes immediately, at which time the effect
+                    // is not yet pushed into the side effect manager, so we need to
+                    // wait for the next tick to dispose or replace it.
+                    Promise.resolve().then(() => {
+                        // using the same disposeId here, which means the old effect ('subscribe' above)
+                        // will be disposed (removed) first, then the new effect ('subscribe' below) will take place.
+                        this.sideEffect.push(
+                            fastboardAPP.memberState.subscribe(saveMemberState),
+                            disposeMemberStateId,
+                        );
+                    });
+                }
+            }),
+            disposeMemberStateId,
+        );
+
         // reset scroll position when page changed
         this.sideEffect.push(
             fastboardAPP.pageIndex.reaction(() => {
@@ -456,3 +471,36 @@ function convertRoomPhase(roomPhase: RoomPhase): IServiceWhiteboardPhase {
         }
     }
 }
+
+const RememberStates: Array<keyof MemberState> = [
+    "strokeColor",
+    "strokeWidth",
+    "textColor",
+    "textSize",
+    "pencilEraserSize",
+];
+
+function initMemberState(app: FastboardApp): void {
+    const raw = localStorage.getItem("FastboardMemberState") || "{}";
+    let memberState: Partial<MemberState> = {};
+    try {
+        memberState = JSON.parse(raw) || {};
+    } catch {
+        // ignore
+    }
+    // The text size is 16 by default, which is too small at the first sight, change it to 36.
+    // Some users may still want to use 16, in that case we have no way to know the purpose.
+    if (!memberState.textSize || memberState.textSize === 16) {
+        memberState.textSize = 36;
+    }
+    // It is safe to call set state here since fastboard is writable now.
+    app.room.setMemberState(memberState);
+}
+
+function saveMemberState(memberState: MemberState): void {
+    const filtered: Record<string, any> = Object.create(null);
+    for (const key of RememberStates) {
+        filtered[key] = memberState[key];
+    }
+    localStorage.setItem("FastboardMemberState", JSON.stringify(filtered));
+}