Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable PrecompileTools.jl #337

Merged
merged 1 commit into from
Oct 28, 2023
Merged

Enable PrecompileTools.jl #337

merged 1 commit into from
Oct 28, 2023

Conversation

hyrodium
Copy link
Owner

@hyrodium hyrodium commented Oct 28, 2023

Before this PR

julia> using BasicBSpline

julia> P = BSplineSpace{3}(KnotVector(1:12))
BSplineSpace{3, Int64, KnotVector{Int64}}(KnotVector([1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12]))

julia> @time changebasis_I(P,P)
  6.380801 seconds (7.65 M allocations: 497.300 MiB, 2.12% gc time, 100.00% compilation time)
8×8 SparseArrays.SparseMatrixCSC{Float64, Int32} with 8 stored entries:
 1.0                            
     1.0                        
         1.0                    
             1.0                
                 1.0            
                     1.0        
                         1.0    
                             1.0

After this PR

julia> using BasicBSpline

julia> P = BSplineSpace{3}(KnotVector(1:12))
BSplineSpace{3, Int64, KnotVector{Int64}}(KnotVector([1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12]))

julia> @time changebasis_I(P,P)
  0.000400 seconds (2.73 k allocations: 249.469 KiB)
8×8 SparseArrays.SparseMatrixCSC{Float64, Int32} with 8 stored entries:
 1.0                            
     1.0                        
         1.0                    
             1.0                
                 1.0            
                     1.0        
                         1.0    
                             1.0

6.380801 seconds → 0.000400 seconds 🎉

@codecov
Copy link

codecov bot commented Oct 28, 2023

Codecov Report

Merging #337 (da6fbe7) into main (2747acb) will decrease coverage by 0.11%.
Report is 1 commits behind head on main.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #337      +/-   ##
==========================================
- Coverage   96.69%   96.59%   -0.11%     
==========================================
  Files          13       14       +1     
  Lines        1515     1528      +13     
==========================================
+ Hits         1465     1476      +11     
- Misses         50       52       +2     
Files Coverage Δ
src/BasicBSpline.jl 100.00% <ø> (ø)
src/_BSplineSpace.jl 98.07% <100.00%> (+0.02%) ⬆️
src/_precompile.jl 100.00% <100.00%> (ø)

... and 2 files with indirect coverage changes

@hyrodium hyrodium merged commit 6ed8f79 into main Oct 28, 2023
11 of 12 checks passed
@hyrodium hyrodium deleted the feature/precompile branch November 11, 2023 04:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant