Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Download outputfiles in background #26

Closed
sverhoeven opened this issue Jan 18, 2023 · 3 comments · Fixed by #33
Closed

Download outputfiles in background #26

sverhoeven opened this issue Jan 18, 2023 · 3 comments · Fixed by #33
Assignees
Milestone

Comments

@sverhoeven
Copy link
Member

Given a job is completed on a remote system without a shared file system.
The output files of the job must be copied back to the file system which can be seen by the bartender service.

In #17 the copying of output files is done during handling of GET /api/job/<jobid> or GET /api/job HTTP requests.
This works fine for small amounts (<1Mb) of bytes to copy, but for big amounts (~40Gb) this will cause timeouts on the HTTP requests.

It would be nice if we could use https://fastapi.tiangolo.com/tutorial/background-tasks or use some file copying queue.

A new job state should be introduced like staging_out to signal that copying of files is happening for a job.
The staging_out job state can also be used to prevent copying multiple times This is not a big issue as files should not change after job completion.

For uploading input files to a remote file system the background task is already used.

sverhoeven added a commit that referenced this issue Jan 18, 2023
@sverhoeven sverhoeven added this to the 0.1.0 milestone Jan 23, 2023
@sverhoeven sverhoeven self-assigned this Jan 24, 2023
@sverhoeven
Copy link
Member Author

Implemented in #33

@sverhoeven
Copy link
Member Author

Doh #33 was merged into wrong branch arq

@sverhoeven sverhoeven reopened this Mar 23, 2023
@sverhoeven
Copy link
Member Author

Fixed in PR #62 and #61

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant