feat(tools): searXNG web search tool #286
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: MICHAEL DESMOND <mdesmond@us.ibm.com>
Tomas2D
requested changes
Jan 20, 2025
Signed-off-by: MICHAEL DESMOND <mdesmond@us.ibm.com>
Signed-off-by: MICHAEL DESMOND <mdesmond@us.ibm.com>
|
@Tomas2D I believe I addressed your feedback. Thanks! I have some docs to go with this tool, see slack message. |
Signed-off-by: MICHAEL DESMOND <mdesmond@us.ibm.com>
Signed-off-by: MICHAEL DESMOND <mdesmond@us.ibm.com>
|
Docs added. |
Tomas2D
reviewed
Jan 22, 2025
Comment on lines
+45
to
+53
| createSnapshot() { | ||
| return { | ||
| results: this.results, | ||
| }; | ||
| } | ||
|
|
||
| loadSnapshot(snapshot: ReturnType<typeof this.createSnapshot>) { | ||
| Object.assign(this, snapshot); | ||
| } |
There was a problem hiding this comment.
It can be removed SearchToolOutput does this.
There was a problem hiding this comment.
Can you elaborate on this one? As far as I can tell these methods are abstract and need to be implemented by subclass.
Tomas2D
requested changes
Jan 22, 2025
Signed-off-by: MICHAEL DESMOND <mdesmond@us.ibm.com>
Tomas2D
approved these changes
Jan 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue(s) does this pull-request address?
Introduces a searXNG web search tool. This provides a convenient option for locally deployed agents that require access to web search. No API key is required and the quality of the results are good.
https://github.com/searxng/searxng
Typical use case is that you spin up a searxng local docker container which provides an api endpoint. Agent can then make web searches using this tool to access the searxng api.
I didn't provide an associated test case because it would require a running searxng instance.
Checklist
yarn lintoryarn lint:fixyarn formatoryarn format:fixyarn test:unityarn test:e2e