-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FIX] Patches multiple streamlit bugs #205
Conversation
Back to draft -- found a problem with document retrieval. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, TVM for all the hard work here @wpfl-dbt !
Good to get @lmwilkigov 's views too
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is fantastic stuff @wpfl-dbt! Much cleaner type handling across the board and great spot on the elastic
@wpfl-dbt you can either run integration tests via github actions (workflow dispatch) or via |
Fixed! Ready for rereview |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
massive thank you @wpfl-dbt !
Context
The streamlit app wasn't useable. Lots of core features simply don't work with the Elasticsearch backend. This fixes as many bugs as I could find.
While #185 closes #184 , this definitely super-closes it.
Changes proposed in this pull request
ELASTIC_SUBSCRIPTION_LEVEL
environment variablechange_selected_model()
function so it doesn't print an API key for all to seeget_files_by_uuid()
into utils to reduce redundancyst.session_state.storage_handler
that used the olditem_uuid=file.uuid, model_type="File"
arguments rather than thePersistableModel
object directlystreamlit_app/
andredbox/
Guidance to review
I don't know how to run integration tests and would appreciate help if that needs doing.
docker compose down
rm -rf data/*
docker compose up core-api embedder ingester streamlit-app --build
Relevant links
AfterValidator
codeThings to check